New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoR.cfg saving issues #1163

Closed
Michael10055 opened this Issue Oct 15, 2016 · 7 comments

Comments

Projects
None yet
4 participants
@Michael10055
Contributor

Michael10055 commented Oct 15, 2016

Some options do not get saved properly on RoR exit:

  • Replay Mode (#1160)
  • Disable Overview Map (#1161)
  • "Preselected Map" (1191)
  • "FOV External" value is overwritten by the current ingame value. (#1192)
  • Vegetation resets to "None" after loading a terrain with vegetation. (#1164)
@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Oct 15, 2016

Member

@Michael10055 Please look at this table: https://github.com/RigsOfRods/rigs-of-rods/wiki/Console-variables and tell me which GVars should volatile (ingame changes don't affect ror.cfg) and which persistent (ingame setting gets exported to ror.cfg).

At the moment, pretty much everything is overwritten by ingame values. This includes "FOV External/Internal".

The "preselected map" (GVar sim_next_terrain) gets cleared once the terrain is loaded. Hence the value saved back to RoR.cfg is empty. I know this is not right.

The "Disable Overview Map" is a plain bug.

Member

only-a-ptr commented Oct 15, 2016

@Michael10055 Please look at this table: https://github.com/RigsOfRods/rigs-of-rods/wiki/Console-variables and tell me which GVars should volatile (ingame changes don't affect ror.cfg) and which persistent (ingame setting gets exported to ror.cfg).

At the moment, pretty much everything is overwritten by ingame values. This includes "FOV External/Internal".

The "preselected map" (GVar sim_next_terrain) gets cleared once the terrain is loaded. Hence the value saved back to RoR.cfg is empty. I know this is not right.

The "Disable Overview Map" is a plain bug.

@only-a-ptr only-a-ptr self-assigned this Oct 15, 2016

@only-a-ptr only-a-ptr added this to the 0.4.7.0 milestone Oct 15, 2016

@Michael10055

This comment has been minimized.

Show comment
Hide comment
@Michael10055

Michael10055 Oct 16, 2016

Contributor

Everything looks fine to me besides the preselected map and the FOV issue.

Contributor

Michael10055 commented Oct 16, 2016

Everything looks fine to me besides the preselected map and the FOV issue.

@disloyalpick

This comment has been minimized.

Show comment
Hide comment
@disloyalpick

disloyalpick Oct 16, 2016

The FOV issue is also present on Linux. But can you tell me how you would reproduce the preselected map issue, please?

disloyalpick commented Oct 16, 2016

The FOV issue is also present on Linux. But can you tell me how you would reproduce the preselected map issue, please?

@Michael10055

This comment has been minimized.

Show comment
Hide comment
@Michael10055

Michael10055 Oct 16, 2016

Contributor

@disloyalpick In RoRConfig, go to the Debug menu, and type a terrain name in the "Preselected Map:" textbox (ex. simple2) and start RoR. It should automatically load the preselected map. Now close RoR and check the textbox in RoRConfig again, the value will be empty. This does not happen with the "Preselected Truck" option.

Contributor

Michael10055 commented Oct 16, 2016

@disloyalpick In RoRConfig, go to the Debug menu, and type a terrain name in the "Preselected Map:" textbox (ex. simple2) and start RoR. It should automatically load the preselected map. Now close RoR and check the textbox in RoRConfig again, the value will be empty. This does not happen with the "Preselected Truck" option.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Oct 16, 2016

Member

Should "Preselected Truck" and associated settings should also persist between sessions, like "Preselected Map"?

Currently, all these settings would get reset:

  • "Preselected Truck";
  • "Preselected TruckConfig";
  • "Enter PreselectedTruck";
Member

only-a-ptr commented Oct 16, 2016

Should "Preselected Truck" and associated settings should also persist between sessions, like "Preselected Map"?

Currently, all these settings would get reset:

  • "Preselected Truck";
  • "Preselected TruckConfig";
  • "Enter PreselectedTruck";
@Michael10055

This comment has been minimized.

Show comment
Hide comment
@Michael10055

Michael10055 Oct 16, 2016

Contributor

Yes, both the Preselected Truck/Map options should be the same between sessions. Both options are very helpful when working on a mod.

Contributor

Michael10055 commented Oct 16, 2016

Yes, both the Preselected Truck/Map options should be the same between sessions. Both options are very helpful when working on a mod.

@Michael10055

This comment has been minimized.

Show comment
Hide comment
@Michael10055

Michael10055 Oct 19, 2016

Contributor

👍 All works fine now.

Contributor

Michael10055 commented Oct 19, 2016

👍 All works fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment