New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-game serverlist not loading #1193

Closed
AnotherFoxGuy opened this Issue Oct 19, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@AnotherFoxGuy
Member

AnotherFoxGuy commented Oct 19, 2016

The in-game server list isn't woking yet, I would like to see it finished before releasing 0.4.7.
The server list is already able to return the list in JSON: http://multiplayer.rigsofrods.org/server-list?json=true

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Oct 19, 2016

Contributor

I would like to see it finished before releasing 0.4.7

👍

Contributor

ulteq commented Oct 19, 2016

I would like to see it finished before releasing 0.4.7

👍

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Oct 19, 2016

Member

Working on it: only-a-ptr@1c1bacc

EDIT: working hard. Unfortunately, our SocketW library can't handle connecting to virtual hosts. And multiplayer.rigsofrods.org is a virtual subdomain.

Finding a lightweight C++ HTTP client library is a mission impossible - my feelings are well summed up by this guy: https://www.reddit.com/r/cpp/comments/3ddigg/rant_is_it_just_me_or_do_cc_http_client_libraries/

I tried https://libwebsockets.org/ but that's very complex server-oriented lib. I failed to get it setup.

Now I'm trying https://github.com/whoshuu/cpr. That requires cURL. Building curl...
EDIT2: turns out 'cpr' builds it's own cURL via Git submodule... nice

Member

only-a-ptr commented Oct 19, 2016

Working on it: only-a-ptr@1c1bacc

EDIT: working hard. Unfortunately, our SocketW library can't handle connecting to virtual hosts. And multiplayer.rigsofrods.org is a virtual subdomain.

Finding a lightweight C++ HTTP client library is a mission impossible - my feelings are well summed up by this guy: https://www.reddit.com/r/cpp/comments/3ddigg/rant_is_it_just_me_or_do_cc_http_client_libraries/

I tried https://libwebsockets.org/ but that's very complex server-oriented lib. I failed to get it setup.

Now I'm trying https://github.com/whoshuu/cpr. That requires cURL. Building curl...
EDIT2: turns out 'cpr' builds it's own cURL via Git submodule... nice

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Oct 20, 2016

Member

@AnotherFoxGuy Fields "current-users" and "max-clients" are being sent as strings instead of ints. Can you fix it please?

I moved the MP repo under RigsOfRods org, since it's already online and almost integrated.

Member

only-a-ptr commented Oct 20, 2016

@AnotherFoxGuy Fields "current-users" and "max-clients" are being sent as strings instead of ints. Can you fix it please?

I moved the MP repo under RigsOfRods org, since it's already online and almost integrated.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Oct 20, 2016

Member

We have a problem with MyGUI. The "MultiListBox" widget used for MP selector is broken. You can only assign items to the first column: https://github.com/MyGUI/mygui/blob/master/MyGUIEngine/src/MyGUI_MultiListBox.cpp#L450-L454.

The google translation of the russian comment says it all.

I'll see what I can do. I can always just grab the widget's sources and put them patched to RoR.

Member

only-a-ptr commented Oct 20, 2016

We have a problem with MyGUI. The "MultiListBox" widget used for MP selector is broken. You can only assign items to the first column: https://github.com/MyGUI/mygui/blob/master/MyGUIEngine/src/MyGUI_MultiListBox.cpp#L450-L454.

The google translation of the russian comment says it all.

I'll see what I can do. I can always just grab the widget's sources and put them patched to RoR.

@AnotherFoxGuy

This comment has been minimized.

Show comment
Hide comment
@AnotherFoxGuy

AnotherFoxGuy Oct 21, 2016

Member

Fields "current-users" and "max-clients" are being sent as strings instead of ints. Can you fix it, please?

I fixed that, but the "has-password", "verified", "is-official" and "port" are now also send as an int.

  {
    "has-password": 0,
    "current-users": 0,
    "max-clients": 20,
    "verified": 1,
    "is-official": 1,
    "ip": "138.68.41.141",
    "port": 12000,
    "terrain-name": "any",
    "name": "Server 1: any"
  }
Member

AnotherFoxGuy commented Oct 21, 2016

Fields "current-users" and "max-clients" are being sent as strings instead of ints. Can you fix it, please?

I fixed that, but the "has-password", "verified", "is-official" and "port" are now also send as an int.

  {
    "has-password": 0,
    "current-users": 0,
    "max-clients": 20,
    "verified": 1,
    "is-official": 1,
    "ip": "138.68.41.141",
    "port": 12000,
    "terrain-name": "any",
    "name": "Server 1: any"
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment