New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some add_animation events ignored #132

Closed
Aivar-RoR opened this Issue Mar 30, 2015 · 3 comments

Comments

Projects
None yet
5 participants
@Aivar-RoR

Aivar-RoR commented Mar 30, 2015

When add_animation in props has a commands_x event, it is ignored by the new truck parser.

props
45,148,146, 0.14, 0.78,0, 0,0,0, fs65-fanswitch.mesh
add_animation 20,0,0, source: event, mode:x-rotation, eventlock, event:commands_10

An example from the log:

14:59:25: Mesh: Loading fs65-fanswitch.mesh.
14:59:25: unknown event (ignored): commands_10
14:59:25: == RigSpawner: ERROR (Keyword props) Unknown animation event: commands_10

The events that are ignored are all valid: http://www.rigsofrods.com/wiki/pages/Keypress_Events

The event is still ignored when commands_10 is changed to COMMANDS_10

Vehicle used: Freightliner FS-65 from http://www.rigsofrods.com/repository/view/5226

@Max98 Max98 added the bug label Mar 30, 2015

@Max98 Max98 added this to the RoR 0.4.5 (Nextstable) milestone Mar 30, 2015

@graysonk95

This comment has been minimized.

Show comment
Hide comment
@graysonk95

graysonk95 Apr 24, 2015

This bug might be related, but I managed to get an add_animation rotation usually triggered by F10 to open with Ctrl+4.
I mashed a bunch of other key combinations but only Ctrl+4 made one of the animations work. All of the F-keys did nothing.
It seems like the controls might be messed up. Ctrl+4 is supposed to turn on some flares, but instead it opened this door:
screenshot_465

I haven't been able to replicate this behavior with any other vehicles yet.

graysonk95 commented Apr 24, 2015

This bug might be related, but I managed to get an add_animation rotation usually triggered by F10 to open with Ctrl+4.
I mashed a bunch of other key combinations but only Ctrl+4 made one of the animations work. All of the F-keys did nothing.
It seems like the controls might be messed up. Ctrl+4 is supposed to turn on some flares, but instead it opened this door:
screenshot_465

I haven't been able to replicate this behavior with any other vehicles yet.

@Max98 Max98 modified the milestones: Post-Nextstable, RoR 0.4.5 (Nextstable) Aug 11, 2015

@Hiradur Hiradur modified the milestones: Post-Nextstable, 0.4.6.0 Oct 24, 2015

@graysonk95

This comment has been minimized.

Show comment
Hide comment
@graysonk95

graysonk95 Dec 17, 2015

I just rediscovered this issue in 0.4.5.1 in my HDX development and found that the only issue is that the keypress events are case sensitive and ALSO space sensitive.
(My previous bug with Ctrl+4 is not able to be recreated).

Prior to 0.4.5.0, "commands_05" was a valid keypressevent, but it is now ignored by the parser.
18:57:12: Mesh: Loading HDX95_hatchstrut.mesh.
18:57:12: unknown event (ignored): commands_05
18:57:12: == RigSpawner: ERROR (Keyword props) Unknown animation event: commands_05

Also, prior to 0.4.5.0 " COMMANDS_05" was acceptable. That is, having a space between "event:" and "COMMANDS_05". Now it is also ignored by the parser (notice the extra space).
18:59:11: Mesh: Loading CB95orangerocker.mesh.
18:59:11: unknown event (ignored): COMMANDS_05
18:59:11: == RigSpawner: ERROR (Keyword props) Unknown animation event: COMMANDS_05

Changing it from "event: commands_05" to "event:COMMANDS_05" fixes the issue completely.
The extra space is likely the issue Aivar is experiencing.
The syntax on the Wiki specifically shows a space between "event:" and your keypressevent, so effectively all "source: event" animations following the Wiki's syntax are now broken for this reason.
http://www.rigsofrods.com/wiki/pages/Truck_Description_File#Add_animation
Long story short, since the old parser was more lax, older vehicles have broken animations due to sloppy syntax and the case sensitivity, or from the space and good syntax.

I am currently on Windows 8.1 and do not have RoR working on any Linux distributions to see if the case sensitivity is specific to Windows.

graysonk95 commented Dec 17, 2015

I just rediscovered this issue in 0.4.5.1 in my HDX development and found that the only issue is that the keypress events are case sensitive and ALSO space sensitive.
(My previous bug with Ctrl+4 is not able to be recreated).

Prior to 0.4.5.0, "commands_05" was a valid keypressevent, but it is now ignored by the parser.
18:57:12: Mesh: Loading HDX95_hatchstrut.mesh.
18:57:12: unknown event (ignored): commands_05
18:57:12: == RigSpawner: ERROR (Keyword props) Unknown animation event: commands_05

Also, prior to 0.4.5.0 " COMMANDS_05" was acceptable. That is, having a space between "event:" and "COMMANDS_05". Now it is also ignored by the parser (notice the extra space).
18:59:11: Mesh: Loading CB95orangerocker.mesh.
18:59:11: unknown event (ignored): COMMANDS_05
18:59:11: == RigSpawner: ERROR (Keyword props) Unknown animation event: COMMANDS_05

Changing it from "event: commands_05" to "event:COMMANDS_05" fixes the issue completely.
The extra space is likely the issue Aivar is experiencing.
The syntax on the Wiki specifically shows a space between "event:" and your keypressevent, so effectively all "source: event" animations following the Wiki's syntax are now broken for this reason.
http://www.rigsofrods.com/wiki/pages/Truck_Description_File#Add_animation
Long story short, since the old parser was more lax, older vehicles have broken animations due to sloppy syntax and the case sensitivity, or from the space and good syntax.

I am currently on Windows 8.1 and do not have RoR working on any Linux distributions to see if the case sensitivity is specific to Windows.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Dec 17, 2015

Member

Whitespace. Right. Sorry about that 😊

Member

only-a-ptr commented Dec 17, 2015

Whitespace. Right. Sorry about that 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment