New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyGUI 3.2.2 not supported #156

Closed
vorot93 opened this Issue Apr 20, 2015 · 15 comments

Comments

Projects
None yet
5 participants
@vorot93
Contributor

vorot93 commented Apr 20, 2015

Compilation of latest git snapshot fails with the following error:

[ 67%] Building CXX object source/main/main_sim/CMakeFiles/RoR.dir/__/gui/GUIInputManager.cpp.o
/home/artem/AUR/rigsofrods-git/src/rigs-of-rods/source/main/gui/GUIInputManager.cpp: В функции-члене «virtual bool GUIInputManager::keyPressed(const OIS::KeyEvent&)»:
/home/artem/AUR/rigsofrods-git/src/rigs-of-rods/source/main/gui/GUIInputManager.cpp:226:22: ошибка: «struct MyGUI::KeyCode» has no member named «toValue»
  int scan_code = key.toValue();
                      ^
source/main/main_sim/CMakeFiles/RoR.dir/build.make:3435: ошибка выполнения рецепта для цели «source/main/main_sim/CMakeFiles/RoR.dir/__/gui/GUIInputManager.cpp.o»
make[2]: *** [source/main/main_sim/CMakeFiles/RoR.dir/__/gui/GUIInputManager.cpp.o] Ошибка 1
CMakeFiles/Makefile2:111: ошибка выполнения рецепта для цели «source/main/main_sim/CMakeFiles/RoR.dir/all»
make[1]: *** [source/main/main_sim/CMakeFiles/RoR.dir/all] Ошибка 2
Makefile:75: ошибка выполнения рецепта для цели «all»
make: *** [all] Ошибка 2

Using MyGUI 3.2.2 compiled against OGRE 1.8 on Arch Linux x86-64.

https://aur.archlinux.org/packages/my/mygui-ogre1.8/PKGBUILD
https://aur.archlinux.org/packages/ri/rigsofrods-git/PKGBUILD

@tritonas00

This comment has been minimized.

Show comment
Hide comment
@tritonas00

tritonas00 Apr 20, 2015

Collaborator

libMyGUI.OgrePlatform.so should be libMyGUI.OgrePlatform.a in your PKGBUILD

also change the angelscript path, /opt/ror is for my modification https://github.com/tritonas00/rigsofrods-git/blob/master/angelscript-2.22.1/PKGBUILD, use /usr/include and /usr/lib

also you should send the game to /opt/rigsofrods. I used /opt/ror because i send all dependencies and game in there, so it want break from updates (e.g boost)

Collaborator

tritonas00 commented Apr 20, 2015

libMyGUI.OgrePlatform.so should be libMyGUI.OgrePlatform.a in your PKGBUILD

also change the angelscript path, /opt/ror is for my modification https://github.com/tritonas00/rigsofrods-git/blob/master/angelscript-2.22.1/PKGBUILD, use /usr/include and /usr/lib

also you should send the game to /opt/rigsofrods. I used /opt/ror because i send all dependencies and game in there, so it want break from updates (e.g boost)

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Apr 20, 2015

Contributor

MyGUI 3.2.2 is not supported. You need SVN revision 4344. Also see http://www.rigsofrods.com/wiki/pages/Compiling_3rd_party_libraries

Contributor

Hiradur commented Apr 20, 2015

MyGUI 3.2.2 is not supported. You need SVN revision 4344. Also see http://www.rigsofrods.com/wiki/pages/Compiling_3rd_party_libraries

@vorot93

This comment has been minimized.

Show comment
Hide comment
@vorot93

vorot93 Apr 20, 2015

Contributor

@tritonas00 Thanks for spotting the error, fixed.

@Hiradur Uh-huh, I see. SVN commit 4549 broke the API, looks like a small patch can correct that.

Contributor

vorot93 commented Apr 20, 2015

@tritonas00 Thanks for spotting the error, fixed.

@Hiradur Uh-huh, I see. SVN commit 4549 broke the API, looks like a small patch can correct that.

@tritonas00

This comment has been minimized.

Show comment
Hide comment
@tritonas00

tritonas00 Apr 20, 2015

Collaborator

No problem :)

Try this https://github.com/MyGUI/mygui/archive/MyGUI3.2.tar.gz, compiled fine here.

Nice you added this beast in aur :). When we have a stable release, i will upload precompiled packages in our repo.

Collaborator

tritonas00 commented Apr 20, 2015

No problem :)

Try this https://github.com/MyGUI/mygui/archive/MyGUI3.2.tar.gz, compiled fine here.

Nice you added this beast in aur :). When we have a stable release, i will upload precompiled packages in our repo.

@vorot93

This comment has been minimized.

Show comment
Hide comment
@vorot93

vorot93 Apr 20, 2015

Contributor

Rejoice! With a bit of sorcery (sedding the deprecated method) AUR package compiles now.
sed -i 's/key.toValue/key.getValue/' ./source/main/gui/GUIInputManager.cpp ./source/main/gui/Console.cpp ./source/main/gui/LobbyGUI.cpp

Contributor

vorot93 commented Apr 20, 2015

Rejoice! With a bit of sorcery (sedding the deprecated method) AUR package compiles now.
sed -i 's/key.toValue/key.getValue/' ./source/main/gui/GUIInputManager.cpp ./source/main/gui/Console.cpp ./source/main/gui/LobbyGUI.cpp

@tritonas00

This comment has been minimized.

Show comment
Hide comment
@tritonas00

tritonas00 Apr 20, 2015

Collaborator

Nice, but why dont just use 3.2?

:P

Collaborator

tritonas00 commented Apr 20, 2015

Nice, but why dont just use 3.2?

:P

@vorot93

This comment has been minimized.

Show comment
Hide comment
@vorot93

vorot93 Apr 21, 2015

Contributor

I am not really sure that RoR is more compatible with 3.2 than 3.2.2. The recommended version is SVN rev. 4344.

Furthermore, mygui-ogre1.8 package is generic, available for inclusion to all Arch Linux packages. It would not be fair to hold back 3.2.2 update just for RoR

Contributor

vorot93 commented Apr 21, 2015

I am not really sure that RoR is more compatible with 3.2 than 3.2.2. The recommended version is SVN rev. 4344.

Furthermore, mygui-ogre1.8 package is generic, available for inclusion to all Arch Linux packages. It would not be fair to hold back 3.2.2 update just for RoR

@tritonas00

This comment has been minimized.

Show comment
Hide comment
@tritonas00

tritonas00 Apr 21, 2015

Collaborator

Fair enough :)

Collaborator

tritonas00 commented Apr 21, 2015

Fair enough :)

@vorot93 vorot93 referenced this issue Apr 24, 2015

Closed

MyGUI 3.2.2 fix #157

@vorot93 vorot93 changed the title from «struct MyGUI::KeyCode» has no member named «toValue» to MyGUI 3.2.2 not supported Apr 24, 2015

@Max98

This comment has been minimized.

Show comment
Hide comment
@Max98

Max98 Jun 1, 2015

Contributor

@skybon Is this fixed yet?

Contributor

Max98 commented Jun 1, 2015

@skybon Is this fixed yet?

@vorot93

This comment has been minimized.

Show comment
Hide comment
@vorot93

vorot93 Jun 1, 2015

Contributor

Nope.

Contributor

vorot93 commented Jun 1, 2015

Nope.

@Max98 Max98 added the enhancement label Jun 1, 2015

@Max98 Max98 added this to the Post-Nextstable milestone Jun 1, 2015

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jun 23, 2015

Contributor

Fixed in Ogre 2.0 branch

Contributor

Hiradur commented Jun 23, 2015

Fixed in Ogre 2.0 branch

@Hubbitus

This comment has been minimized.

Show comment
Hide comment
@Hubbitus

Hubbitus Jan 17, 2016

In doc you state: "This is available in recent Fedora repositories. If the dnf install described above has succeeded, then you will not need to build from source."

But rawhide contains 3.2.1-7 version and build fails in same way:

/builddir/build/BUILD/rigs-of-rods-23c619a9010e375ea7357ef190ff683f2beac5d4/source/main/RoRPrerequisites.h:66:39: error: 'struct MyGUI::KeyCode' has no member named 'toValue'
 # define MYGUI_GET_SCANCODE(KEY) (KEY.toValue())

https://kojipkgs.fedoraproject.org//work/tasks/6410/12586410/build.log

Does Ogre 2.0 branch ready? Should it be used now?

Hubbitus commented Jan 17, 2016

In doc you state: "This is available in recent Fedora repositories. If the dnf install described above has succeeded, then you will not need to build from source."

But rawhide contains 3.2.1-7 version and build fails in same way:

/builddir/build/BUILD/rigs-of-rods-23c619a9010e375ea7357ef190ff683f2beac5d4/source/main/RoRPrerequisites.h:66:39: error: 'struct MyGUI::KeyCode' has no member named 'toValue'
 # define MYGUI_GET_SCANCODE(KEY) (KEY.toValue())

https://kojipkgs.fedoraproject.org//work/tasks/6410/12586410/build.log

Does Ogre 2.0 branch ready? Should it be used now?

@Hubbitus

This comment has been minimized.

Show comment
Hide comment
@Hubbitus

Hubbitus Jan 17, 2016

It seams just version in condition is incorrect. Should be:

$ cat rigsofrods-0.4.6.0-mygui-gt-2.2.1.patch
diff -NurEbBH rigs-of-rods-23c619a9010e375ea7357ef190ff683f2beac5d4.orig/source/main/RoRPrerequisites.h rigs-of-rods-23c619a9010e375ea7357ef190ff683f2beac5d4/source/main/RoRPrerequisites.h
--- rigs-of-rods-23c619a9010e375ea7357ef190ff683f2beac5d4.orig/source/main/RoRPrerequisites.h   2016-01-07 23:27:32.000000000 +0300
+++ rigs-of-rods-23c619a9010e375ea7357ef190ff683f2beac5d4/source/main/RoRPrerequisites.h        2016-01-17 20:21:46.465101398 +0300
@@ -60,7 +60,7 @@

 #include <MyGUI_Prerequest.h> // Forward declarations

-#if MYGUI_VERSION >= 0x030202
+#if MYGUI_VERSION >= 0x030201
 #      define MYGUI_GET_SCANCODE(KEY) (KEY.getValue())
 #else
 #      define MYGUI_GET_SCANCODE(KEY) (KEY.toValue())

Hubbitus commented Jan 17, 2016

It seams just version in condition is incorrect. Should be:

$ cat rigsofrods-0.4.6.0-mygui-gt-2.2.1.patch
diff -NurEbBH rigs-of-rods-23c619a9010e375ea7357ef190ff683f2beac5d4.orig/source/main/RoRPrerequisites.h rigs-of-rods-23c619a9010e375ea7357ef190ff683f2beac5d4/source/main/RoRPrerequisites.h
--- rigs-of-rods-23c619a9010e375ea7357ef190ff683f2beac5d4.orig/source/main/RoRPrerequisites.h   2016-01-07 23:27:32.000000000 +0300
+++ rigs-of-rods-23c619a9010e375ea7357ef190ff683f2beac5d4/source/main/RoRPrerequisites.h        2016-01-17 20:21:46.465101398 +0300
@@ -60,7 +60,7 @@

 #include <MyGUI_Prerequest.h> // Forward declarations

-#if MYGUI_VERSION >= 0x030202
+#if MYGUI_VERSION >= 0x030201
 #      define MYGUI_GET_SCANCODE(KEY) (KEY.getValue())
 #else
 #      define MYGUI_GET_SCANCODE(KEY) (KEY.toValue())
@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 17, 2016

Contributor

@Hubbitus This has already been fixed in master: #547

Contributor

Hiradur commented Jan 17, 2016

@Hubbitus This has already been fixed in master: #547

Hubbitus added a commit to Hubbitus/Fedora-packaging that referenced this issue Jan 17, 2016

rigsofrods major update
* Sun Jan 17 2016 Pavel Alexeev <Pahan@Hubbitus.info> - 0.4.6.0-0.5.git.23c619a
- Does not compiled on ARM - RigsOfRods/rigs-of-rods#608. Excluded.

* Sat Jan 16 2016 Pavel Alexeev <Pahan@Hubbitus.info> - 0.4.6.0-0.4.git.23c619a
- Report segfault: RigsOfRods/rigs-of-rods#550 - temporary disable caelum (it is optional dep).
- Add BR openssl-devel
- Report new segfault: RigsOfRods/rigs-of-rods#602
- Hit issue RigsOfRods/rigs-of-rods#156. Add patch igsofrods-0.4.6.0-mygui-gt-2.2.1.patch.

* Sun Jan 10 2016 Pavel Alexeev <Pahan@Hubbitus.info> - 0.4.6.0-0.3.git.23c619a
- Update to 23c619a9010e375ea7357ef190ff683f2beac5d4 - RigsOfRods/rigs-of-rods#534 closed. Build without angelscript until RigsOfRods/rigs-of-rods#530 resolved.
- Add patch rigsofrods-0.4.6.0-without-angelscript.patch for 534 issue as sugested in RigsOfRods/rigs-of-rods@23c619a.

* Fri Jan 08 2016 Pavel Alexeev <Pahan@Hubbitus.info> - 0.4.6.0-0.2.git.c10f9ac
- Use autodownloader to easy download high quality pack (can't be redistributed RigsOfRods/rigs-of-rods#542)

* Wed Jan 06 2016 Pavel Alexeev <Pahan@Hubbitus.info> - 0.4.6.0-0.1.git.c10f9ac
- Update to upstream release 0.4.6.0 (RigsOfRods/rigs-of-rods#145 (comment)).
- Project now on github.
- Fill RigsOfRods/rigs-of-rods#530 about outdated AngelScript API usage. Disable AngelScript for now.
- Step to unreliased versions (due to the RigsOfRods/rigs-of-rods#145)
- Fill RigsOfRods/rigs-of-rods#534 (ScriptEngine.h: No such file or directory) - add temporary patch1: rigsofrods-0.4.6.0-build-without-angelscript.patch
- Upstream informed about incorrect fsf address: RigsOfRods/rigs-of-rods#538
- Fill RigsOfRods/rigs-of-rods#541 about required /usr/bin//plugins.cfg
@Hubbitus

This comment has been minimized.

Show comment
Hide comment
@Hubbitus

Hubbitus Jan 18, 2016

Thank you!

Hubbitus commented Jan 18, 2016

Thank you!

Hubbitus added a commit to Hubbitus/Fedora-packaging that referenced this issue Jan 25, 2016

0.4.6.0-0.6.git.3e56c07
- Issue with compilation on ARM resolved (RigsOfRods/rigs-of-rods#608).
- Drop rigsofrods-0.4.6.0-mygui-gt-2.2.1.patch as it incorporated (RigsOfRods/rigs-of-rods#156 -> RigsOfRods/rigs-of-rods#547)

Hubbitus added a commit to Hubbitus/rpm-rigsofrods that referenced this issue Jan 31, 2017

rigsofrods major update
* Sun Jan 17 2016 Pavel Alexeev <Pahan@Hubbitus.info> - 0.4.6.0-0.5.git.23c619a
- Does not compiled on ARM - RigsOfRods/rigs-of-rods#608. Excluded.

* Sat Jan 16 2016 Pavel Alexeev <Pahan@Hubbitus.info> - 0.4.6.0-0.4.git.23c619a
- Report segfault: RigsOfRods/rigs-of-rods#550 - temporary disable caelum (it is optional dep).
- Add BR openssl-devel
- Report new segfault: RigsOfRods/rigs-of-rods#602
- Hit issue RigsOfRods/rigs-of-rods#156. Add patch igsofrods-0.4.6.0-mygui-gt-2.2.1.patch.

* Sun Jan 10 2016 Pavel Alexeev <Pahan@Hubbitus.info> - 0.4.6.0-0.3.git.23c619a
- Update to 23c619a9010e375ea7357ef190ff683f2beac5d4 - RigsOfRods/rigs-of-rods#534 closed. Build without angelscript until RigsOfRods/rigs-of-rods#530 resolved.
- Add patch rigsofrods-0.4.6.0-without-angelscript.patch for 534 issue as sugested in RigsOfRods/rigs-of-rods@23c619a.

* Fri Jan 08 2016 Pavel Alexeev <Pahan@Hubbitus.info> - 0.4.6.0-0.2.git.c10f9ac
- Use autodownloader to easy download high quality pack (can't be redistributed RigsOfRods/rigs-of-rods#542)

* Wed Jan 06 2016 Pavel Alexeev <Pahan@Hubbitus.info> - 0.4.6.0-0.1.git.c10f9ac
- Update to upstream release 0.4.6.0 (RigsOfRods/rigs-of-rods#145 (comment)).
- Project now on github.
- Fill RigsOfRods/rigs-of-rods#530 about outdated AngelScript API usage. Disable AngelScript for now.
- Step to unreliased versions (due to the RigsOfRods/rigs-of-rods#145)
- Fill RigsOfRods/rigs-of-rods#534 (ScriptEngine.h: No such file or directory) - add temporary patch1: rigsofrods-0.4.6.0-build-without-angelscript.patch
- Upstream informed about incorrect fsf address: RigsOfRods/rigs-of-rods#538
- Fill RigsOfRods/rigs-of-rods#541 about required /usr/bin//plugins.cfg

Hubbitus added a commit to Hubbitus/rpm-rigsofrods that referenced this issue Jan 31, 2017

0.4.6.0-0.6.git.3e56c07
- Issue with compilation on ARM resolved (RigsOfRods/rigs-of-rods#608).
- Drop rigsofrods-0.4.6.0-mygui-gt-2.2.1.patch as it incorporated (RigsOfRods/rigs-of-rods#156 -> RigsOfRods/rigs-of-rods#547)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment