New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much smoke emitted for default smoke line #392

Closed
negativeice opened this Issue Aug 13, 2015 · 15 comments

Comments

Projects
None yet
7 participants
@negativeice

negativeice commented Aug 13, 2015

The default smoke line emits to much smoke to constantly blocking your view.

screenshot_1

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 13, 2015

If you are using the first person camera then it shouldn't be a problem.

ghost commented Aug 13, 2015

If you are using the first person camera then it shouldn't be a problem.

@Michael10055

This comment has been minimized.

Show comment
Hide comment
@Michael10055

Michael10055 Aug 13, 2015

Contributor

Most people don't want to use the first person camera all the time...It's still a bug that should be looked into.

Contributor

Michael10055 commented Aug 13, 2015

Most people don't want to use the first person camera all the time...It's still a bug that should be looked into.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 13, 2015

It is more realistic and more fun with lots of smoke, and 1st person view is the most realistic. I only leave 1st person view when connecting a trailer or loading something.

ghost commented Aug 13, 2015

It is more realistic and more fun with lots of smoke, and 1st person view is the most realistic. I only leave 1st person view when connecting a trailer or loading something.

@DirtGamer301

This comment has been minimized.

Show comment
Hide comment
@DirtGamer301

DirtGamer301 Aug 13, 2015

But not everyone and if you say "Everything you can't see from 1st person camera doesn't need to be fixed" you'd only have to create the front end and visible interior (from 1st person view straight forward) and say done the mod is. But that's not what it's about.

DirtGamer301 commented Aug 13, 2015

But not everyone and if you say "Everything you can't see from 1st person camera doesn't need to be fixed" you'd only have to create the front end and visible interior (from 1st person view straight forward) and say done the mod is. But that's not what it's about.

@Max98 Max98 added the bug label Aug 14, 2015

@Max98 Max98 added this to the Post-Nextstable milestone Aug 14, 2015

@Hiradur Hiradur modified the milestones: Post-Nextstable, 0.4.6.0 Oct 24, 2015

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Nov 18, 2015

Contributor

Is the amount of emitted smoke the same as in older versions?

Contributor

Hiradur commented Nov 18, 2015

Is the amount of emitted smoke the same as in older versions?

@DarthCainRor

This comment has been minimized.

Show comment
Hide comment
@DarthCainRor

DarthCainRor Nov 18, 2015

No. The game emits a lot more in .4.5 than it did on .38

DarthCainRor commented Nov 18, 2015

No. The game emits a lot more in .4.5 than it did on .38

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 19, 2015

Member

@DarthCainRor That's curious, I didn't touch it at all. What about v 0.4.0.7. Can you test all versions and post screenshots for comparsion, pls?

Member

only-a-ptr commented Nov 19, 2015

@DarthCainRor That's curious, I didn't touch it at all. What about v 0.4.0.7. Can you test all versions and post screenshots for comparsion, pls?

@DarthCainRor

This comment has been minimized.

Show comment
Hide comment
@DarthCainRor

DarthCainRor Nov 21, 2015

Full throttle with Box5's W900.
0.38
screenshot_193
0.4.0.7
2015-11-20_14-48-32
0.4.5
screenshot_205

Also, on a side note from talking with others in the RoR Skype channel, vehicles using the new turbo code, smoke fine, ones without do not.

DarthCainRor commented Nov 21, 2015

Full throttle with Box5's W900.
0.38
screenshot_193
0.4.0.7
2015-11-20_14-48-32
0.4.5
screenshot_205

Also, on a side note from talking with others in the RoR Skype channel, vehicles using the new turbo code, smoke fine, ones without do not.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 21, 2015

Member

@DarthCainRor Oh, that's quite insane, indeed 😄
And thanks for the "side note", that's actually a very promising clue.

EDIT: LOL, this is in all Box5W900 trucks:

egnoption
Member

only-a-ptr commented Nov 21, 2015

@DarthCainRor Oh, that's quite insane, indeed 😄
And thanks for the "side note", that's actually a very promising clue.

EDIT: LOL, this is in all Box5W900 trucks:

egnoption

@only-a-ptr only-a-ptr assigned Max98 and unassigned only-a-ptr Nov 21, 2015

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 21, 2015

Member

This is for Max98 to fix.
The problem is BeamEngine::curTurboRPM - 0.4.0.7 always udpates it. In 045, it's only updated when [engturbo] is used. With Box5's W900, it's zero all the time.
EDIT: In fact, BeamEngine::hasturbo is "false" for W900 in 045 😦

Member

only-a-ptr commented Nov 21, 2015

This is for Max98 to fix.
The problem is BeamEngine::curTurboRPM - 0.4.0.7 always udpates it. In 045, it's only updated when [engturbo] is used. With Box5's W900, it's zero all the time.
EDIT: In fact, BeamEngine::hasturbo is "false" for W900 in 045 😦

@only-a-ptr only-a-ptr assigned only-a-ptr and unassigned Max98 Nov 21, 2015

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 21, 2015

Member

I changed my mind about the assignment ... I'll fix it. And clean the code in the process ☺️

Member

only-a-ptr commented Nov 21, 2015

I changed my mind about the assignment ... I'll fix it. And clean the code in the process ☺️

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 21, 2015

Member

Hmm... third thought :) ... I won't just fix the code as it is. Instead, I'll do THE THING 😈

Member

only-a-ptr commented Nov 21, 2015

Hmm... third thought :) ... I won't just fix the code as it is. Instead, I'll do THE THING 😈

@negativeice

This comment has been minimized.

Show comment
Hide comment
@negativeice

negativeice Nov 21, 2015

what thing? :D also when can we expect a new version? :)

negativeice commented Nov 21, 2015

what thing? :D also when can we expect a new version? :)

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Nov 22, 2015

Contributor

@only-a-ptr When doing that you should also look at #428

@negativeice no eta, you can follow the progress on the 0.4.6 milestone here: https://github.com/RigsOfRods/rigs-of-rods/milestones/0.4.6.0

Contributor

Hiradur commented Nov 22, 2015

@only-a-ptr When doing that you should also look at #428

@negativeice no eta, you can follow the progress on the 0.4.6 milestone here: https://github.com/RigsOfRods/rigs-of-rods/milestones/0.4.6.0

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 23, 2015

Member

@Hiradur @Max98 Heh, just found a bug with "engoption: stallRPM" setting. "StallRPM" is used as "IdleRPM" and "IdleRPM" is ignored. The bug was introduced by Ulteq when he extended "engoption" in 2013: fa1916e#diff-d47d357a254e0b1523e9a63fa4af7382R93

Since it's been there from the start, it has to be considered a feature.

Member

only-a-ptr commented Nov 23, 2015

@Hiradur @Max98 Heh, just found a bug with "engoption: stallRPM" setting. "StallRPM" is used as "IdleRPM" and "IdleRPM" is ignored. The bug was introduced by Ulteq when he extended "engoption" in 2013: fa1916e#diff-d47d357a254e0b1523e9a63fa4af7382R93

Since it's been there from the start, it has to be considered a feature.

@only-a-ptr only-a-ptr changed the title from To much smoke emitted for default smoke line to Too much smoke emitted for default smoke line Nov 25, 2015

ulteq added a commit to ulteq/rigs-of-rods that referenced this issue Jan 20, 2016

ulteq added a commit to ulteq/rigs-of-rods that referenced this issue Jan 21, 2016

@ulteq ulteq closed this in #627 Jan 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment