New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_inertia is not working anymore #393

Closed
negativeice opened this Issue Aug 13, 2015 · 6 comments

Comments

Projects
None yet
4 participants
@negativeice

negativeice commented Aug 13, 2015

all my mods use set_inertia to smooth out the commands so they don't start or stop abruptly, but that seems to be absent now.

@Max98 Max98 added the bug label Aug 20, 2015

@Max98 Max98 added this to the RoR 0.4.5.1 milestone Aug 20, 2015

@Max98 Max98 modified the milestones: 0.4.5.2, 0.4.5.1 Aug 27, 2015

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 9, 2015

Member

@negativeice : I need clarification: are you referring to "set_inertia_defaults" directive, or optional inertia attributes of "commands[2]"? This is important.

Also, please give me specific testing scenario:

  • A download link to a vehicle (try the vehicle yourself and post RoR.log)
  • Controls to use for testing
  • Description of desired and actual behavior
Member

only-a-ptr commented Nov 9, 2015

@negativeice : I need clarification: are you referring to "set_inertia_defaults" directive, or optional inertia attributes of "commands[2]"? This is important.

Also, please give me specific testing scenario:

  • A download link to a vehicle (try the vehicle yourself and post RoR.log)
  • Controls to use for testing
  • Description of desired and actual behavior
@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 9, 2015

Member

Found issue

RigSpawner: The "should I use values from set_inertia_defaults?" condition is broken.

Original spawner checks validity of command's inertia args first and if those are invalid, checks if the set_inertia_defaults values:

else if (cmdInertia && (inertia_startDelay > 0 || inertia_stopDelay > 0))

new spawner checks validity of command's inertia-args twice (instead of args-once and defaults-once), so values from set_inertia_defaults can never apply.

https://github.com/RigsOfRods/rigs-of-rods/blob/master/source/main/physics/input_output/RigSpawner.cpp#L3639

Member

only-a-ptr commented Nov 9, 2015

Found issue

RigSpawner: The "should I use values from set_inertia_defaults?" condition is broken.

Original spawner checks validity of command's inertia args first and if those are invalid, checks if the set_inertia_defaults values:

else if (cmdInertia && (inertia_startDelay > 0 || inertia_stopDelay > 0))

new spawner checks validity of command's inertia-args twice (instead of args-once and defaults-once), so values from set_inertia_defaults can never apply.

https://github.com/RigsOfRods/rigs-of-rods/blob/master/source/main/physics/input_output/RigSpawner.cpp#L3639

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 17, 2015

Member

Fixed

Member

only-a-ptr commented Nov 17, 2015

Fixed

@only-a-ptr only-a-ptr closed this Nov 17, 2015

only-a-ptr added a commit to only-a-ptr/rigs-of-rods that referenced this issue Nov 17, 2015

[fix RigsOfRods#393] RigParser: set_inertia_defaults working again.
Internal: classes <OptionalInertia> + <DefaultInertia> removed, using class <Inertia> for all purposes.
@negativeice

This comment has been minimized.

Show comment
Hide comment
@negativeice

negativeice Nov 22, 2015

Sorry for the late reply man, that thanks for fixing :) greatly appreciated

also another thing i noticed is that shocks are not as smooth as they should be.

And example is on my jcb when you curl the coupler all the way down and lift the front end, the couple jerks rapidly.

negativeice commented Nov 22, 2015

Sorry for the late reply man, that thanks for fixing :) greatly appreciated

also another thing i noticed is that shocks are not as smooth as they should be.

And example is on my jcb when you curl the coupler all the way down and lift the front end, the couple jerks rapidly.

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Nov 22, 2015

Contributor

@negativeice please open a new ticket for that and always include links to the vehicles you are talking about.

Contributor

Hiradur commented Nov 22, 2015

@negativeice please open a new ticket for that and always include links to the vehicles you are talking about.

@negativeice

This comment has been minimized.

Show comment
Hide comment
@negativeice

negativeice commented Nov 23, 2015

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment