New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flares2: Parser too strict (enforces separation by space) #408

Closed
xTakedownJnR opened this Issue Aug 17, 2015 · 6 comments

Comments

Projects
None yet
4 participants
@xTakedownJnR

xTakedownJnR commented Aug 17, 2015

For some reason the truck parser doesn't recognize what the "flares2" section is and completely ignores it. flares2 link: http://www.rigsofrods.com/wiki/pages/Truck_Description_File#Flares2

-What happens-
The flares that use flares2 don't work.

How to reproduce
1.Spawn the vehicle
2. Turn on the lights (the flares that use flares2 don't show up.

Log
21:19:13: ===== LOADING VEHICLE: Pete379Logger.truck
21:19:13: == Parsing vehicle file: Pete379Logger.truck
21:19:13: == Parsing done, report:

FF3300 ERROR #FFFFFF (Section guisettings)

Line (64): speedoMax 136.794
Message: Invalid line, ignoring...

FF3300 ERROR #FFFFFF (Section flares2)

Line (1234): 87, 86, 90, 0.231, 0.713, 2.5, f, -1, 0, 0.40, tracks/brakeflare
Message: Invalid line, ignoring...

FF3300 ERROR #FFFFFF (Section flares2)

Line (1235): 87, 86, 90, 0.284, 0.713, 2.5, f, -1, 0, 0.40, tracks/brakeflare
Message: Invalid line, ignoring...

FF3300 ERROR #FFFFFF (Section flares2)

Line (1236): 87, 86, 90, 0.335, 0.713, 2.5, f, -1, 0, 0.40, tracks/brakeflare
Message: Invalid line, ignoring...

FF3300 ERROR #FFFFFF (Section flares2)

Line (1237): 87, 86, 90, 0.661, 0.713, 2.5, f, -1, 0, 0.40, tracks/brakeflare
Message: Invalid line, ignoring...

FF3300 ERROR #FFFFFF (Section flares2)

Line (1238): 87, 86, 90, 0.713, 0.713, 2.5, f, -1, 0, 0.40, tracks/brakeflare
Message: Invalid line, ignoring...

FF3300 ERROR #FFFFFF (Section flares2)

Line (1239): 87, 86, 90, 0.764, 0.713, 2.5, f, -1, 0, 0.40, tracks/brakeflare
Message: Invalid line, ignoring...

FF3300 ERROR #FFFFFF (Section flares2)

Line (1241): 29, 28, 30, 0.07, -0.5, 3, f, -1, 0, 1, tracks/brakeflare
Message: Invalid line, ignoring...

FF3300 ERROR #FFFFFF (Section flares2)

Line (1242): 29, 28, 30, 0.90, -0.5, 3, f, -1, 0, 1, tracks/brakeflare
Message: Invalid line, ignoring...

FF3300 ERROR #FFFFFF (Section flares2)

Line (1244): 29, 28, 30, 0.07, -0.10, 3, R, -1, 0, 0.6, tracks/flare
Message: Invalid line, ignoring...

FF3300 ERROR #FFFFFF (Section flares2)

Line (1245): 29, 28, 30, 0.90, -0.10, 3, R, -1, 0, 0.6, tracks/flare
Message: Invalid line, ignoring...

FF3300 ERROR #FFFFFF (Section flares2)

Line (1247): 29, 28, 30, 0.07, -0.5, 3, l, -1, -1, 1, tracks/brakeflare
Message: Invalid line, ignoring...

FF3300 ERROR #FFFFFF (Section flares2)

Line (1248): 29, 28, 30, 0.90, -0.5, 3, r, -1, -1, 1, tracks/brakeflare
Message: Invalid line, ignoring...

FF3300 ERROR #FFFFFF (Section flares2)

Line (1250): 29, 28, 30, 0.07, -0.5, 3, b, -1, 0, 1, tracks/brakeflare
Message: Invalid line, ignoring...

FF3300 ERROR #FFFFFF (Section flares2)

Line (1251): 29, 28, 30, 0.90, -0.5, 3, b, -1, 0, 1, tracks/brakeflare
Message: Invalid line, ignoring...<addr>

Link to truck: http://www.rigsofrods.com/repository/view/5400

@xTakedownJnR xTakedownJnR changed the title from Flares2 nor working to Flares2 not working Aug 17, 2015

@DarthCainRor

This comment has been minimized.

Show comment
Hide comment
@DarthCainRor

DarthCainRor Aug 17, 2015

No probem on my T800. Flares2 all work properly.
screenshot_15

DarthCainRor commented Aug 17, 2015

No probem on my T800. Flares2 all work properly.
screenshot_15

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 17, 2015

Oh, the Ctrl+1,2,etc flares? Working fine here too.

ghost commented Aug 17, 2015

Oh, the Ctrl+1,2,etc flares? Working fine here too.

@DarthCainRor

This comment has been minimized.

Show comment
Hide comment
@DarthCainRor

DarthCainRor Aug 17, 2015

No. He means flares that are coded as flares2, rather than flares. I do see this error on some of my things though. All have values larger than 1. So I wonder if the parser doesn't know what to do in that instance.

Edit: I don't know. They seem to work when they want to. I'm not sure what's causing it.

DarthCainRor commented Aug 17, 2015

No. He means flares that are coded as flares2, rather than flares. I do see this error on some of my things though. All have values larger than 1. So I wonder if the parser doesn't know what to do in that instance.

Edit: I don't know. They seem to work when they want to. I'm not sure what's causing it.

@DarthCainRor

This comment has been minimized.

Show comment
Hide comment
@DarthCainRor

DarthCainRor Aug 17, 2015

Found the Issue. Remove the comma between the last number, and the material for the flare. The old parser didn't mind if there was a comma there and ignored it, but the new one doesn't like the comma there, as it isn't there in the description.

DarthCainRor commented Aug 17, 2015

Found the Issue. Remove the comma between the last number, and the material for the flare. The old parser didn't mind if there was a comma there and ignored it, but the new one doesn't like the comma there, as it isn't there in the description.

@xTakedownJnR

This comment has been minimized.

Show comment
Hide comment
@xTakedownJnR

xTakedownJnR Aug 17, 2015

Thanks DarthCain :)

xTakedownJnR commented Aug 17, 2015

Thanks DarthCain :)

@Max98 Max98 added the bug label Aug 20, 2015

@Max98 Max98 added this to the RoR 0.4.5.1 milestone Aug 20, 2015

@Max98 Max98 modified the milestones: 0.4.5.2, 0.4.5.1 Aug 27, 2015

@only-a-ptr only-a-ptr changed the title from Flares2 not working to Flares2: Parser too strict (enforces separation by space) Oct 19, 2015

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Oct 19, 2015

Member

I'm going to loosen the parser rules anyway, just to avoid cases like this in the future.

Member

only-a-ptr commented Oct 19, 2015

I'm going to loosen the parser rules anyway, just to avoid cases like this in the future.

@only-a-ptr only-a-ptr added coding and removed bug labels Oct 19, 2015

@only-a-ptr only-a-ptr closed this in 3c85ad2 Jan 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment