New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semi automatic shift mode missing #413

Closed
DirtGamer301 opened this Issue Aug 18, 2015 · 14 comments

Comments

Projects
None yet
4 participants
@DirtGamer301

DirtGamer301 commented Aug 18, 2015

In 0.38, the automatic gearbox was more like a half-automatic one. If you wanted to you were able to shift, but RoR still shifted itself.
This for example was useful for going into reverse gear if you didn't want to use Arcade Control (which would make oyu go into reverse by pressing the brake). But also, if you wanted to up/downshift different then the automatic gearbox would.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 18, 2015

Yep, it's the only thing I don't like about 0.4 is that it automatically shifts into reverse. I want to keep the brake down and not go in reverse unless I want to.

ghost commented Aug 18, 2015

Yep, it's the only thing I don't like about 0.4 is that it automatically shifts into reverse. I want to keep the brake down and not go in reverse unless I want to.

@DirtGamer301

This comment has been minimized.

Show comment
Hide comment
@DirtGamer301

DirtGamer301 Aug 18, 2015

Disable Arcade Controls (remove the tick in RoRConfig). That's not exactly what I was talking about ^^

DirtGamer301 commented Aug 18, 2015

Disable Arcade Controls (remove the tick in RoRConfig). That's not exactly what I was talking about ^^

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost commented Aug 18, 2015

Oh, OK.

@Max98 Max98 changed the title from [low priority request] Half automatic to Half automatic Aug 18, 2015

@Max98 Max98 added the request label Aug 18, 2015

@Max98

This comment has been minimized.

Show comment
Hide comment
@Max98

Max98 Aug 18, 2015

Contributor

Stop using the [tags] on your issues titles.

Contributor

Max98 commented Aug 18, 2015

Stop using the [tags] on your issues titles.

@Hiradur Hiradur added this to the 0.4.6.0 milestone Oct 24, 2015

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Nov 18, 2015

Contributor

Shifting is screwed up in general, is that correct? I can't get it to shift in most of the modes (use Q to switch between shifting modes)

logic for manual shifting is handled here:
https://github.com/RigsOfRods/rigs-of-rods/blob/master/source/main/gameplay/LandVehicleSimulation.cpp#L324
and the shift function is here:
https://github.com/RigsOfRods/rigs-of-rods/blob/master/source/main/gameplay/BeamEngine.cpp#L1022

Contributor

Hiradur commented Nov 18, 2015

Shifting is screwed up in general, is that correct? I can't get it to shift in most of the modes (use Q to switch between shifting modes)

logic for manual shifting is handled here:
https://github.com/RigsOfRods/rigs-of-rods/blob/master/source/main/gameplay/LandVehicleSimulation.cpp#L324
and the shift function is here:
https://github.com/RigsOfRods/rigs-of-rods/blob/master/source/main/gameplay/BeamEngine.cpp#L1022

@DirtGamer301

This comment has been minimized.

Show comment
Hide comment
@DirtGamer301

DirtGamer301 Nov 18, 2015

I'm sorry, I can't give any information of fully manually shifting. I only use automatic and manual with automatic clutch.

DirtGamer301 commented Nov 18, 2015

I'm sorry, I can't give any information of fully manually shifting. I only use automatic and manual with automatic clutch.

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Nov 18, 2015

Contributor

Downshifting works in no mode for me. Shifting up/down is impossible in automatic mode in neutral.

Contributor

Hiradur commented Nov 18, 2015

Downshifting works in no mode for me. Shifting up/down is impossible in automatic mode in neutral.

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Nov 19, 2015

Contributor

My bad, downshifting is on 'z' but I pressed 'y' due to the German keyboard layout.

@only-a-ptr
There is a mistake in RigSpawner.cpp: https://github.com/RigsOfRods/rigs-of-rods/blob/master/source/main/physics/input_output/RigSpawner.cpp#L5921

"semi automatic" is not the same as "manual shift, auto clutch"

a real semi automatic mode is missing.

Contributor

Hiradur commented Nov 19, 2015

My bad, downshifting is on 'z' but I pressed 'y' due to the German keyboard layout.

@only-a-ptr
There is a mistake in RigSpawner.cpp: https://github.com/RigsOfRods/rigs-of-rods/blob/master/source/main/physics/input_output/RigSpawner.cpp#L5921

"semi automatic" is not the same as "manual shift, auto clutch"

a real semi automatic mode is missing.

@DirtGamer301

This comment has been minimized.

Show comment
Hide comment
@DirtGamer301

DirtGamer301 Nov 19, 2015

@Hiradur
On a german keyboard it's y to downshift so you should've done correctly :p
A to up-, and Y to downshift.

DirtGamer301 commented Nov 19, 2015

@Hiradur
On a german keyboard it's y to downshift so you should've done correctly :p
A to up-, and Y to downshift.

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Nov 19, 2015

Contributor

Doesn't seem to be this way on Linux.

Contributor

Hiradur commented Nov 19, 2015

Doesn't seem to be this way on Linux.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 20, 2015

Member

@Hiradur /RigSpawner: It's the same in 0.4.0.7:

if (gearboxMode == "Manual shift - Auto clutch")

However, the enum-field names can be deceiving. Please investigate what the code really does. I'm sorry but myself I've only ever used keyboard+arcade controls 😊

Member

only-a-ptr commented Nov 20, 2015

@Hiradur /RigSpawner: It's the same in 0.4.0.7:

if (gearboxMode == "Manual shift - Auto clutch")

However, the enum-field names can be deceiving. Please investigate what the code really does. I'm sorry but myself I've only ever used keyboard+arcade controls 😊

@Hiradur Hiradur self-assigned this Nov 20, 2015

@Hiradur Hiradur changed the title from Half automatic to semi automatic shift mode missing Nov 20, 2015

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Nov 22, 2015

Contributor

fixed

Contributor

Hiradur commented Nov 22, 2015

fixed

@Hiradur Hiradur closed this Nov 22, 2015

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 23, 2015

Member

@Hiradur "Fixed" by no commit? 😄 Details please.

Member

only-a-ptr commented Nov 23, 2015

@Hiradur "Fixed" by no commit? 😄 Details please.

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Nov 23, 2015

Contributor

Right, where are my manners 😊
fixed by Hiradur@97a9aa0

Didn't touch the enum, instead changed the logic to resemble the behaviour of 0.38

Contributor

Hiradur commented Nov 23, 2015

Right, where are my manners 😊
fixed by Hiradur@97a9aa0

Didn't touch the enum, instead changed the logic to resemble the behaviour of 0.38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment