New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed free cam goes away when entering a vehicle #419

Closed
DirtGamer301 opened this Issue Aug 21, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@DirtGamer301

DirtGamer301 commented Aug 21, 2015

If this wasn't supposed to be like that, I'd like to report it as a bug because the way it behaved in older versions was better IMO.
If you're in fixed free cam, and enter a vehicle, the free cam will go away and you'll be in normal 3th person view at the vehicle.
Edit: The same thing happens when being in a vehicle, going into free cam, then into fixed free cam and leave the vehicle, just that the camera will be at RoRBot for sure.

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Oct 18, 2015

Contributor

I agree, the camera should still be in fixed free cam mode and keep it's position when entering a vehicle

Contributor

Hiradur commented Oct 18, 2015

I agree, the camera should still be in fixed free cam mode and keep it's position when entering a vehicle

@Hiradur Hiradur added the bug label Oct 18, 2015

@Hiradur Hiradur added this to the 0.4.6.0 milestone Oct 24, 2015

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 16, 2015

Member

The reason I changed the behavior was a bugfix, actually: Previously, RoR rembembered camera state globally, including cinecam number in vehicle. This caused crashes when player switched vehicles to one with less cinecams, and general confusion. I changed this to per-vehicle setting: each vehicle rembembers it's camera, and so does the character.

I'm OK with porting the old behavior back as a config option. However, I'm not quite sure whether to enable it by default. Personally, I prefer when the camera stays the way I switched it, that's more RoR-like. But at the same time, resetting camera on enter/exit is more "typical", and we need "typical" for new players. Even previous authors (Theshark + Ulteq) added "typical" features like arcade controls for leisure players.

For now, I'm going to add these new RoR.conf options:

    Camera_EnterVehicle_KeepFixedFreeCam     | bool, default false
    Camera_ExitVehicle_KeepFixedFreeCam      | bool, default false
Member

only-a-ptr commented Nov 16, 2015

The reason I changed the behavior was a bugfix, actually: Previously, RoR rembembered camera state globally, including cinecam number in vehicle. This caused crashes when player switched vehicles to one with less cinecams, and general confusion. I changed this to per-vehicle setting: each vehicle rembembers it's camera, and so does the character.

I'm OK with porting the old behavior back as a config option. However, I'm not quite sure whether to enable it by default. Personally, I prefer when the camera stays the way I switched it, that's more RoR-like. But at the same time, resetting camera on enter/exit is more "typical", and we need "typical" for new players. Even previous authors (Theshark + Ulteq) added "typical" features like arcade controls for leisure players.

For now, I'm going to add these new RoR.conf options:

    Camera_EnterVehicle_KeepFixedFreeCam     | bool, default false
    Camera_ExitVehicle_KeepFixedFreeCam      | bool, default false

@only-a-ptr only-a-ptr self-assigned this Nov 16, 2015

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 17, 2015

Member

Done

Member

only-a-ptr commented Nov 17, 2015

Done

@only-a-ptr only-a-ptr closed this Nov 17, 2015

only-a-ptr added a commit to only-a-ptr/rigs-of-rods that referenced this issue Nov 17, 2015

[fixes RigsOfRods#419] Added option to keep 'static' camera when ente…
…ring/exiting vehicle.

Added options:
    Camera_EnterVehicle_KeepFixedFreeCam     | bool, default false
    Camera_ExitVehicle_KeepFixedFreeCam      | bool, default false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment