New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build broken on Linux #438

Closed
schmatzler opened this Issue Sep 22, 2015 · 23 comments

Comments

Projects
None yet
3 participants
@schmatzler

schmatzler commented Sep 22, 2015

I've tried to build the current HEAD c692412 on Slackware64 here (gcc 4.9.3).

It fails at 24% with this error:

/tmp/txz/rigsofrods-20150922/source/main/gfx/SkyManager.cpp: In member function 'void SkyManager::loadScript(Ogre::String, int, int)':
/tmp/txz/rigsofrods-20150922/source/main/gfx/SkyManager.cpp:97:40: error: 'class Caelum::CaelumPlugin' has no member named 'loadCaelumSystemFromScript'
   Caelum::CaelumPlugin::getSingleton().loadCaelumSystemFromScript (mCaelumSystem, script);
                                        ^
make[2]: *** [source/main/main_sim/CMakeFiles/RoR.dir/__/gfx/SkyManager.cpp.o] Error 1
@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur
Contributor

Hiradur commented Sep 22, 2015

@schmatzler

This comment has been minimized.

Show comment
Hide comment
@schmatzler

schmatzler Sep 22, 2015

Whoops, I overlooked that you updated this, too. Now it builds.

Slackware can get new packages now :)

schmatzler commented Sep 22, 2015

Whoops, I overlooked that you updated this, too. Now it builds.

Slackware can get new packages now :)

@schmatzler schmatzler closed this Sep 22, 2015

@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Mailaender

Mailaender Jan 8, 2016

Are there plans to make this work with regular versions of Caelum?

Mailaender commented Jan 8, 2016

Are there plans to make this work with regular versions of Caelum?

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 8, 2016

Contributor

Are there plans to make this work with regular versions of Caelum?

define "regular versions of Caelum", please. AFAIK there is no central repository anymore.

Contributor

Hiradur commented Jan 8, 2016

Are there plans to make this work with regular versions of Caelum?

define "regular versions of Caelum", please. AFAIK there is no central repository anymore.

@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Mailaender

Mailaender Jan 8, 2016

Current version 0.6.1 available via e.g. https://software.opensuse.org/package/caelum

Mailaender commented Jan 8, 2016

Current version 0.6.1 available via e.g. https://software.opensuse.org/package/caelum

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 8, 2016

Contributor

0.6.1 is very old and development died after that release. Now various forks exist with minor fixes of bugs and builds.

The 0.6.1 release probably doesn't work with Ogre 1.9. You'd need Ogre 1.8 instead.

Contributor

Hiradur commented Jan 8, 2016

0.6.1 is very old and development died after that release. Now various forks exist with minor fixes of bugs and builds.

The 0.6.1 release probably doesn't work with Ogre 1.9. You'd need Ogre 1.8 instead.

@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Mailaender

Mailaender Jan 8, 2016

A united upstream instead of multiple per-project forks would make packaging easier.

Mailaender commented Jan 8, 2016

A united upstream instead of multiple per-project forks would make packaging easier.

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 8, 2016

Contributor

An attempt to do this was done here: https://bitbucket.org/ogreaddons/

Our Caelum repository is a fork of that one because it didn't build and there was no activity for months. But I see it's been fixed now: https://bitbucket.org/ogreaddons/caelum/commits/8620df4b7c43fb1ced39487ff551d42d65c32da8

Another problem with the ogreaddons repo is that these addons were once bundled with Ogitor and then pulled out of that. The CMake files are still taylored towards Ogitor and there is no commit history, making it very hard to track what has been patched and what not.

Ideally the initiative for central Ogre addon repos would come from the Ogre project itself but I don't think they have the manpower to do that.

Contributor

Hiradur commented Jan 8, 2016

An attempt to do this was done here: https://bitbucket.org/ogreaddons/

Our Caelum repository is a fork of that one because it didn't build and there was no activity for months. But I see it's been fixed now: https://bitbucket.org/ogreaddons/caelum/commits/8620df4b7c43fb1ced39487ff551d42d65c32da8

Another problem with the ogreaddons repo is that these addons were once bundled with Ogitor and then pulled out of that. The CMake files are still taylored towards Ogitor and there is no commit history, making it very hard to track what has been patched and what not.

Ideally the initiative for central Ogre addon repos would come from the Ogre project itself but I don't think they have the manpower to do that.

@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Mailaender

Mailaender Jan 8, 2016

A tagged release that is known to work and build would help as well.

Mailaender commented Jan 8, 2016

A tagged release that is known to work and build would help as well.

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 8, 2016

Contributor

https://github.com/RigsOfRods/caelum works and I could tag a release, but which version number should I choose?

Contributor

Hiradur commented Jan 8, 2016

https://github.com/RigsOfRods/caelum works and I could tag a release, but which version number should I choose?

@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 8, 2016

Contributor

Right, I copied it from our wiki and I can't remember why it's named so, probably to make clear that 0.6.1 won't work.

Contributor

Hiradur commented Jan 8, 2016

Right, I copied it from our wiki and I can't remember why it's named so, probably to make clear that 0.6.1 won't work.

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 8, 2016

Contributor

Before making a release the latest patches from https://code.google.com/p/caelum/source/list
should be applied (they are missing, I checked some).

Paged Geometry would need a release as well.

Anybody up for the task?

Contributor

Hiradur commented Jan 8, 2016

Before making a release the latest patches from https://code.google.com/p/caelum/source/list
should be applied (they are missing, I checked some).

Paged Geometry would need a release as well.

Anybody up for the task?

@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Mailaender

Mailaender Jan 9, 2016

I imported https://github.com/Mailaender/caelum preserving the commit history and the bug tracker entries from Google Code. Can transfer ownership.

Mailaender commented Jan 9, 2016

I imported https://github.com/Mailaender/caelum preserving the commit history and the bug tracker entries from Google Code. Can transfer ownership.

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 9, 2016

Contributor

@Mailaender Let me look into it later. I think our Caelum repo is imported from https://bitbucket.org/ogreaddons/ but I didn't create it and I don't know why it was chosen over the official repo on Google code.
Maybe I just replace our repo with a new import.

Contributor

Hiradur commented Jan 9, 2016

@Mailaender Let me look into it later. I think our Caelum repo is imported from https://bitbucket.org/ogreaddons/ but I didn't create it and I don't know why it was chosen over the official repo on Google code.
Maybe I just replace our repo with a new import.

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 10, 2016

Contributor

@Mailaender I imported the caelum repo so we don't have to deal with user permissions: https://github.com/RigsOfRods/ogre-caelum

However, as it turned out, it doesn't compile with Ogre 1.9 and now I'm not really sure what I should do. Fix it and ditch the other one or keep the old one, apply the missing patches and forget about it. I'm leaning towards the latter, what do you think?

EDIT: 3rd option: Remove it entirely and use the one from ogreaddons, now that they finally merged in the build fix. But in this case I could not tag a release. It would keep everything centralized though, hmm...

Contributor

Hiradur commented Jan 10, 2016

@Mailaender I imported the caelum repo so we don't have to deal with user permissions: https://github.com/RigsOfRods/ogre-caelum

However, as it turned out, it doesn't compile with Ogre 1.9 and now I'm not really sure what I should do. Fix it and ditch the other one or keep the old one, apply the missing patches and forget about it. I'm leaning towards the latter, what do you think?

EDIT: 3rd option: Remove it entirely and use the one from ogreaddons, now that they finally merged in the build fix. But in this case I could not tag a release. It would keep everything centralized though, hmm...

@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Mailaender

Mailaender Jan 10, 2016

I don't know. If Ogre Addons is the proper upstream than you probably should join the team. I asked for the same thing there: https://bitbucket.org/ogreaddons/caelum/issues/1/tagged-releases Let's see if anyone responds.

Mailaender commented Jan 10, 2016

I don't know. If Ogre Addons is the proper upstream than you probably should join the team. I asked for the same thing there: https://bitbucket.org/ogreaddons/caelum/issues/1/tagged-releases Let's see if anyone responds.

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 11, 2016

Contributor

@Mailaender I decided to patch https://github.com/Mailaender/caelum for Ogre 1.9 and use this for a release.
Reason: It's from the official source and guaranteed to not be a downgrade from older versions. It contains samples and documentation, something which the repo at ogreaddons is lacking. The ogreaddons repo is also lacking license information, contributors etc.

That being said, if the ogreaddons team would like to use our repo instead of theirs they should go ahead so we could then centralize all efforts.

I'm going to prepare the repo and tag the release later today.

Contributor

Hiradur commented Jan 11, 2016

@Mailaender I decided to patch https://github.com/Mailaender/caelum for Ogre 1.9 and use this for a release.
Reason: It's from the official source and guaranteed to not be a downgrade from older versions. It contains samples and documentation, something which the repo at ogreaddons is lacking. The ogreaddons repo is also lacking license information, contributors etc.

That being said, if the ogreaddons team would like to use our repo instead of theirs they should go ahead so we could then centralize all efforts.

I'm going to prepare the repo and tag the release later today.

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 11, 2016

Contributor

@Mailaender Here it goes: https://github.com/RigsOfRods/ogre-caelum/releases/tag/v0.6.3
This version is compatible with Ogre 1.9 and 1.8, maybe older and newer versions, too

Contributor

Hiradur commented Jan 11, 2016

@Mailaender Here it goes: https://github.com/RigsOfRods/ogre-caelum/releases/tag/v0.6.3
This version is compatible with Ogre 1.9 and 1.8, maybe older and newer versions, too

@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 11, 2016

Contributor
Contributor

Hiradur commented Jan 11, 2016

@Mailaender

This comment has been minimized.

Show comment
Hide comment
@Mailaender

Mailaender Jan 11, 2016

This also finally fixes the RoR compilation. https://build.opensuse.org/request/show/353149

Mailaender commented Jan 11, 2016

This also finally fixes the RoR compilation. https://build.opensuse.org/request/show/353149

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 12, 2016

Contributor

@Mailaender Awesome!

Contributor

Hiradur commented Jan 12, 2016

@Mailaender Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment