New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoRbot's seating location. #448

Closed
DarthCainRor opened this Issue Nov 5, 2015 · 13 comments

Comments

Projects
None yet
4 participants
@DarthCainRor

DarthCainRor commented Nov 5, 2015

In the newer versions of the game, with the newer RORbot, when seated in a user defined -seat.mesh, it appears that he is off set, and not seated at the same origin as the old RoRbot.

Vehicles: Any vehicle with seats that rorbot sits in, either custom seats or standard ones.

Old position:
screenshot_186

New position:
screenshot_181

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 9, 2015

Member

@DarthCainRor Thanks for reporting.
Please specify "newer versions of RoR" - which version was the first to introduce this issue? Was it 0.4.5 or 0.4.0.x?

Member

only-a-ptr commented Nov 9, 2015

@DarthCainRor Thanks for reporting.
Please specify "newer versions of RoR" - which version was the first to introduce this issue? Was it 0.4.5 or 0.4.0.x?

@DarthCainRor

This comment has been minimized.

Show comment
Hide comment
@DarthCainRor

DarthCainRor Nov 9, 2015

I have no idea. I used .38 until .4.5 was release. As far as I can tell it probably has to do with the new model for RoRBot, but I don't know what version he was originally replaced in.

DarthCainRor commented Nov 9, 2015

I have no idea. I used .38 until .4.5 was release. As far as I can tell it probably has to do with the new model for RoRBot, but I don't know what version he was originally replaced in.

@DarthCainRor

This comment has been minimized.

Show comment
Hide comment
@DarthCainRor

DarthCainRor Nov 9, 2015

Well, after a bit of checking I can confirm that their origins are not identical. That may have something to do with it. New RoRbot is centered while old, is not.

DarthCainRor commented Nov 9, 2015

Well, after a bit of checking I can confirm that their origins are not identical. That may have something to do with it. New RoRbot is centered while old, is not.

@DirtGamer301

This comment has been minimized.

Show comment
Hide comment
@DirtGamer301

DirtGamer301 Nov 9, 2015

#247
I'll add this as both issues have to do with RoRBot.

DirtGamer301 commented Nov 9, 2015

#247
I'll add this as both issues have to do with RoRBot.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 9, 2015

Member

@DarthCainRor : Thanks for investigating the RoRbot mesh. I'll check the code.

Member

only-a-ptr commented Nov 9, 2015

@DarthCainRor : Thanks for investigating the RoRbot mesh. I'll check the code.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 12, 2015

Member

@DarthCainRor : Version 0.4.0.7 works fine.

I tried copying 0407's RoRbot to 0.4.5. Result: hands started to move when steering (known issue in animations) and RoRbot is now seated perfectly in the passenger seat.

Member

only-a-ptr commented Nov 12, 2015

@DarthCainRor : Version 0.4.0.7 works fine.

I tried copying 0407's RoRbot to 0.4.5. Result: hands started to move when steering (known issue in animations) and RoRbot is now seated perfectly in the passenger seat.

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Nov 13, 2015

Contributor

Hagdervriese made the new RoRBot (or the animations at least, not sure). Maybe he can help out.

@only-a-ptr Are you sure the problem is not the different origin of the meshes?

Contributor

Hiradur commented Nov 13, 2015

Hagdervriese made the new RoRBot (or the animations at least, not sure). Maybe he can help out.

@only-a-ptr Are you sure the problem is not the different origin of the meshes?

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 13, 2015

Member

@Hiradur Quite sure. It's a detail.

Furthermore, animations, by definition, move RoRBot's body parts around the origin, possibly moving the entire character around the origin. Even though oldbot's origin is off, the "driving" animation might be perfectly centered. And vice versa, even though newbot's origin is centered, the "driving" animation might be off - possibly to the level where it places newbot to a different seat!

Member

only-a-ptr commented Nov 13, 2015

@Hiradur Quite sure. It's a detail.

Furthermore, animations, by definition, move RoRBot's body parts around the origin, possibly moving the entire character around the origin. Even though oldbot's origin is off, the "driving" animation might be perfectly centered. And vice versa, even though newbot's origin is centered, the "driving" animation might be off - possibly to the level where it places newbot to a different seat!

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 13, 2015

Member

@DarthCainRor I just opened DAF's truckfile and this is what I found:

 props
     1,4,50,  1.7, 0.1, 0.2, 0, 0, 0, seat.mesh
     49,51,0, 1.7, 0.9, 0.2, 0, 0, 0, seat.mesh

Try erasing the passenger seat and see what happens. I suspect old/new parser behave diffently when multiple seats are present.

Member

only-a-ptr commented Nov 13, 2015

@DarthCainRor I just opened DAF's truckfile and this is what I found:

 props
     1,4,50,  1.7, 0.1, 0.2, 0, 0, 0, seat.mesh
     49,51,0, 1.7, 0.9, 0.2, 0, 0, 0, seat.mesh

Try erasing the passenger seat and see what happens. I suspect old/new parser behave diffently when multiple seats are present.

@DarthCainRor

This comment has been minimized.

Show comment
Hide comment
@DarthCainRor

DarthCainRor Nov 13, 2015

I can test it when I get off work, but even the rorbot in my custom seat on one of the trucks I'm working on sits off centered.

DarthCainRor commented Nov 13, 2015

I can test it when I get off work, but even the rorbot in my custom seat on one of the trucks I'm working on sits off centered.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 15, 2015

Member

@DarthCainRor It's true, the code compensates for old-rorbot's decentered origin. I'm working on it.

EDIT: Ooops...

screenshot_2

Member

only-a-ptr commented Nov 15, 2015

@DarthCainRor It's true, the code compensates for old-rorbot's decentered origin. I'm working on it.

EDIT: Ooops...

screenshot_2

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 15, 2015

Member

Fixed.

Member

only-a-ptr commented Nov 15, 2015

Fixed.

@only-a-ptr only-a-ptr closed this Nov 15, 2015

@DarthCainRor

This comment has been minimized.

Show comment
Hide comment
@DarthCainRor

DarthCainRor Nov 16, 2015

Awesome! Sorry I didn't test. I've been extremely busy as of late.

DarthCainRor commented Nov 16, 2015

Awesome! Sorry I didn't test. I've been extremely busy as of late.

only-a-ptr added a commit to only-a-ptr/rigs-of-rods that referenced this issue Nov 17, 2015

[fix] RoRBot's seating position in vehicle. Fixes RigsOfRods#448
Issues:
* If multiple driver-seats were defined, spawner used the last one instead of the first one as required for compatibility.
* The code positioned RoRBot slightly left to compensate for old model's decentered origin. The new model is centered, so this hack was removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment