New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add_Animation Source "shifterlin" is Broken #488

Closed
graysonk95 opened this Issue Dec 19, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@graysonk95

graysonk95 commented Dec 19, 2015

Unlike the syntax-related issue with some add_animations (#132), source "shifterlin" is completely broken with no errors given in RoR.log.

Last working version was 0.4.0.7.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Dec 22, 2015

Member

@graysonk95

  • Can you link me to some vehicles which use it?
  • What is "shifterlin" supposed to do, anyway? The name isn't exactly self-explanatory.
Member

only-a-ptr commented Dec 22, 2015

@graysonk95

  • Can you link me to some vehicles which use it?
  • What is "shifterlin" supposed to do, anyway? The name isn't exactly self-explanatory.
@graysonk95

This comment has been minimized.

Show comment
Hide comment
@graysonk95

graysonk95 Dec 26, 2015

I've used it in the past (and plan to continue to use it) for my Allison push-button shifter displays: http://www.rigsofrods.com/repository/view/5711
Here is how it is supposed to operate:
https://youtu.be/GdfDF0WLIUE
In 0.4.5.1, it just stays stuck on "D6". No errors in ror.log.

My guess is "shifterlin" is short for "linear shifter", because it animates gears in a linear fashion rather than in an H-pattern. Shifterlin is useful for making a display of the current gear.
You are right. Many animations are not well documented (or could use examples).
It took me until 2 weeks ago to notice there was an ignition "TRUCK_TOGGLE_CONTACT" animation event because it was in an example, rater than in the full list of events.

graysonk95 commented Dec 26, 2015

I've used it in the past (and plan to continue to use it) for my Allison push-button shifter displays: http://www.rigsofrods.com/repository/view/5711
Here is how it is supposed to operate:
https://youtu.be/GdfDF0WLIUE
In 0.4.5.1, it just stays stuck on "D6". No errors in ror.log.

My guess is "shifterlin" is short for "linear shifter", because it animates gears in a linear fashion rather than in an H-pattern. Shifterlin is useful for making a display of the current gear.
You are right. Many animations are not well documented (or could use examples).
It took me until 2 weeks ago to notice there was an ignition "TRUCK_TOGGLE_CONTACT" animation event because it was in an example, rater than in the full list of events.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Dec 27, 2015

Member

@graysonk95 Thanks for the details.

Member

only-a-ptr commented Dec 27, 2015

@graysonk95 Thanks for the details.

ulteq added a commit to ulteq/rigs-of-rods that referenced this issue Jan 13, 2016

only-a-ptr added a commit that referenced this issue Jan 14, 2016

Merge pull request #568 from ulteq/shifterlinFix
[Bugfix] Fixes add_animation source 'shifterlin' (#488)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment