New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build without Angelscript is broken #534

Closed
Hubbitus opened this Issue Jan 7, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@Hubbitus

Hubbitus commented Jan 7, 2016

Building

[  0%] Building CXX object source/main/main_sim/CMakeFiles/RoR.dir/MainThread.cpp.o
/home/pasha/SOFT/rpmbuild/BUILD/rigs-of-rods-c10f9acd5ccc6147a507ec2baed8f2e564d94bd0/source/main/main_sim/MainThread.cpp:63:26: fatal error: ScriptEngine.h: No such file or directory
 #include "ScriptEngine.h"

In MainThread.cpp:63 I have changed

#include "ScriptEngine.h"

to

#include "scripting/ScriptEngine.h"

then got:

/home/pasha/SOFT/rpmbuild/BUILD/rigs-of-rods-c10f9acd5ccc6147a507ec2baed8f2e564d94bd0/source/main/scripting/ScriptEngine.h:33:47: fatal error: scriptdictionary/scriptdictionary.h: No such file or directory
 #include "scriptdictionary/scriptdictionary.h"

such file I found in ./angelscript_addons/scriptdictionary/scriptdictionary.h, but I configure it without angelscript (-DROR_USE_ANGELSCRIPT="FALSE") due to the rely RoR on outdated API - #530

Please help.

@Hiradur Hiradur changed the title from error: ScriptEngine.h: No such file or directory to Build without Angelscript is broken Jan 7, 2016

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 7, 2016

Contributor

You are probably the first to build without Angelscript in years and the build without AS is apparently broken.

diff --git a/source/main/main_sim/MainThread.cpp b/source/main/main_sim/MainThread.cpp
index 5aa93ff..d325997 100644
--- a/source/main/main_sim/MainThread.cpp
+++ b/source/main/main_sim/MainThread.cpp
@@ -60,7 +60,9 @@
 #include "RigEditor_Config.h"
 #include "RigEditor_Main.h"
 #include "RoRFrameListener.h"
-#include "ScriptEngine.h"
+#ifdef USE_ANGELSCRIPT
+  #include "ScriptEngine.h"
+#endif
 #include "Scripting.h"
 #include "Settings.h"
 #include "Skin.h"
@@ -237,7 +239,9 @@ void MainThread::Go()
    // Create legacy RoRFrameListener

    gEnv->frameListener = new RoRFrameListener();
+#ifdef USE_ANGELSCRIPT
    ScriptEngine::getSingleton().SetFrameListener(gEnv->frameListener);
+#endif

    gEnv->frameListener->enablePosStor = BSETTING("Position Storage", false);

This should fix the build but RoR crashes when loading a terrain with:

An exception has occured!: OGRE EXCEPTION(2:InvalidParametersException): Cannot find requested affector type. in ParticleSystemManager::_createAffector at /home/hiradur/rigs-of-rods-as/source/ogre/OgreMain/src/OgreParticleSystemManager.cpp (line 304) / url: http://wiki.rigsofrods.com/index.php?title=Error_2#ParticleSystemManager::_createAffector
Contributor

Hiradur commented Jan 7, 2016

You are probably the first to build without Angelscript in years and the build without AS is apparently broken.

diff --git a/source/main/main_sim/MainThread.cpp b/source/main/main_sim/MainThread.cpp
index 5aa93ff..d325997 100644
--- a/source/main/main_sim/MainThread.cpp
+++ b/source/main/main_sim/MainThread.cpp
@@ -60,7 +60,9 @@
 #include "RigEditor_Config.h"
 #include "RigEditor_Main.h"
 #include "RoRFrameListener.h"
-#include "ScriptEngine.h"
+#ifdef USE_ANGELSCRIPT
+  #include "ScriptEngine.h"
+#endif
 #include "Scripting.h"
 #include "Settings.h"
 #include "Skin.h"
@@ -237,7 +239,9 @@ void MainThread::Go()
    // Create legacy RoRFrameListener

    gEnv->frameListener = new RoRFrameListener();
+#ifdef USE_ANGELSCRIPT
    ScriptEngine::getSingleton().SetFrameListener(gEnv->frameListener);
+#endif

    gEnv->frameListener->enablePosStor = BSETTING("Position Storage", false);

This should fix the build but RoR crashes when loading a terrain with:

An exception has occured!: OGRE EXCEPTION(2:InvalidParametersException): Cannot find requested affector type. in ParticleSystemManager::_createAffector at /home/hiradur/rigs-of-rods-as/source/ogre/OgreMain/src/OgreParticleSystemManager.cpp (line 304) / url: http://wiki.rigsofrods.com/index.php?title=Error_2#ParticleSystemManager::_createAffector
@Hubbitus

This comment has been minimized.

Show comment
Hide comment
@Hubbitus

Hubbitus Jan 7, 2016

This should fix the build but it crashes at runtime with:

It is not much help then :)
But AngelScript listed as optional, is not?

Hubbitus commented Jan 7, 2016

This should fix the build but it crashes at runtime with:

It is not much help then :)
But AngelScript listed as optional, is not?

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 7, 2016

Contributor

But AngelScript listed as optional, is not?

It was made optional years ago and should still be, but we've never build without it for years so that's why the build probably broke at some point.

Sorry for all the trouble, we should focus on upgrading AS so it can be easily pulled from software repositories.

Contributor

Hiradur commented Jan 7, 2016

But AngelScript listed as optional, is not?

It was made optional years ago and should still be, but we've never build without it for years so that's why the build probably broke at some point.

Sorry for all the trouble, we should focus on upgrading AS so it can be easily pulled from software repositories.

@Hubbitus

This comment has been minimized.

Show comment
Hide comment
@Hubbitus

Hubbitus Jan 7, 2016

As stated in my spec it was reported long time ago: http://redmine.rigsofrods.com/issues/1033 (now dead link) :(

Hubbitus commented Jan 7, 2016

As stated in my spec it was reported long time ago: http://redmine.rigsofrods.com/issues/1033 (now dead link) :(

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 10, 2016

Contributor

fixed in 23c619a

Please note the required manual edit of water.particle, as mentioned in the Readme.

Contributor

Hiradur commented Jan 10, 2016

fixed in 23c619a

Please note the required manual edit of water.particle, as mentioned in the Readme.

@Hiradur Hiradur closed this Jan 10, 2016

Hubbitus added a commit to Hubbitus/Fedora-packaging that referenced this issue Jan 17, 2016

rigsofrods major update
* Sun Jan 17 2016 Pavel Alexeev <Pahan@Hubbitus.info> - 0.4.6.0-0.5.git.23c619a
- Does not compiled on ARM - RigsOfRods/rigs-of-rods#608. Excluded.

* Sat Jan 16 2016 Pavel Alexeev <Pahan@Hubbitus.info> - 0.4.6.0-0.4.git.23c619a
- Report segfault: RigsOfRods/rigs-of-rods#550 - temporary disable caelum (it is optional dep).
- Add BR openssl-devel
- Report new segfault: RigsOfRods/rigs-of-rods#602
- Hit issue RigsOfRods/rigs-of-rods#156. Add patch igsofrods-0.4.6.0-mygui-gt-2.2.1.patch.

* Sun Jan 10 2016 Pavel Alexeev <Pahan@Hubbitus.info> - 0.4.6.0-0.3.git.23c619a
- Update to 23c619a9010e375ea7357ef190ff683f2beac5d4 - RigsOfRods/rigs-of-rods#534 closed. Build without angelscript until RigsOfRods/rigs-of-rods#530 resolved.
- Add patch rigsofrods-0.4.6.0-without-angelscript.patch for 534 issue as sugested in RigsOfRods/rigs-of-rods@23c619a.

* Fri Jan 08 2016 Pavel Alexeev <Pahan@Hubbitus.info> - 0.4.6.0-0.2.git.c10f9ac
- Use autodownloader to easy download high quality pack (can't be redistributed RigsOfRods/rigs-of-rods#542)

* Wed Jan 06 2016 Pavel Alexeev <Pahan@Hubbitus.info> - 0.4.6.0-0.1.git.c10f9ac
- Update to upstream release 0.4.6.0 (RigsOfRods/rigs-of-rods#145 (comment)).
- Project now on github.
- Fill RigsOfRods/rigs-of-rods#530 about outdated AngelScript API usage. Disable AngelScript for now.
- Step to unreliased versions (due to the RigsOfRods/rigs-of-rods#145)
- Fill RigsOfRods/rigs-of-rods#534 (ScriptEngine.h: No such file or directory) - add temporary patch1: rigsofrods-0.4.6.0-build-without-angelscript.patch
- Upstream informed about incorrect fsf address: RigsOfRods/rigs-of-rods#538
- Fill RigsOfRods/rigs-of-rods#541 about required /usr/bin//plugins.cfg

Hubbitus added a commit to Hubbitus/rpm-rigsofrods that referenced this issue Jan 31, 2017

rigsofrods major update
* Sun Jan 17 2016 Pavel Alexeev <Pahan@Hubbitus.info> - 0.4.6.0-0.5.git.23c619a
- Does not compiled on ARM - RigsOfRods/rigs-of-rods#608. Excluded.

* Sat Jan 16 2016 Pavel Alexeev <Pahan@Hubbitus.info> - 0.4.6.0-0.4.git.23c619a
- Report segfault: RigsOfRods/rigs-of-rods#550 - temporary disable caelum (it is optional dep).
- Add BR openssl-devel
- Report new segfault: RigsOfRods/rigs-of-rods#602
- Hit issue RigsOfRods/rigs-of-rods#156. Add patch igsofrods-0.4.6.0-mygui-gt-2.2.1.patch.

* Sun Jan 10 2016 Pavel Alexeev <Pahan@Hubbitus.info> - 0.4.6.0-0.3.git.23c619a
- Update to 23c619a9010e375ea7357ef190ff683f2beac5d4 - RigsOfRods/rigs-of-rods#534 closed. Build without angelscript until RigsOfRods/rigs-of-rods#530 resolved.
- Add patch rigsofrods-0.4.6.0-without-angelscript.patch for 534 issue as sugested in RigsOfRods/rigs-of-rods@23c619a.

* Fri Jan 08 2016 Pavel Alexeev <Pahan@Hubbitus.info> - 0.4.6.0-0.2.git.c10f9ac
- Use autodownloader to easy download high quality pack (can't be redistributed RigsOfRods/rigs-of-rods#542)

* Wed Jan 06 2016 Pavel Alexeev <Pahan@Hubbitus.info> - 0.4.6.0-0.1.git.c10f9ac
- Update to upstream release 0.4.6.0 (RigsOfRods/rigs-of-rods#145 (comment)).
- Project now on github.
- Fill RigsOfRods/rigs-of-rods#530 about outdated AngelScript API usage. Disable AngelScript for now.
- Step to unreliased versions (due to the RigsOfRods/rigs-of-rods#145)
- Fill RigsOfRods/rigs-of-rods#534 (ScriptEngine.h: No such file or directory) - add temporary patch1: rigsofrods-0.4.6.0-build-without-angelscript.patch
- Upstream informed about incorrect fsf address: RigsOfRods/rigs-of-rods#538
- Fill RigsOfRods/rigs-of-rods#541 about required /usr/bin//plugins.cfg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment