New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Props Misplaced/Chassis Deformed #820

Closed
graysonk95 opened this Issue Apr 6, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@graysonk95

graysonk95 commented Apr 6, 2016

I haven't come across any other vehicles with this same issue in 0.4.6.0, but on my HDX all of the props are misplaced and/or the flexbodies are deformed in a strange way at spawn.

0.4.0.7 had a weird deformation at spawn which was fixed for 0.4.5.1 and up, but for some reason my bus (which was perfectly fine in 0.4.5.1) now is experiencing a similar deformation in 0.4.6.0 (all nightlies and release candidates).

All of the switches and buttons are quite far off from where they should be
screenshot_2016-04-06_13-10-05_1

The doors are flexbodies and they are tweaked at spawn
screenshot_2016-04-06_13-14-38_1

I haven't had any time to troubleshoot to see if there's anything on my end I can change (in case this is a parsing issue with beam rigidity or something), but regardless, something changed between 0.4.5.1 and 0.4.6.0.

@ulteq ulteq added bug graphics labels Apr 6, 2016

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Apr 6, 2016

Contributor

Are you able to reproduce the props misplacement every time you spawn that truck?

the flexbodies are deformed in a strange way at spawn

Can you make two comparison screenshots (0.4.5.1 vs. 0.4.6.0)?

all of the props are misplaced

That sounds like a parsing issue.

Contributor

ulteq commented Apr 6, 2016

Are you able to reproduce the props misplacement every time you spawn that truck?

the flexbodies are deformed in a strange way at spawn

Can you make two comparison screenshots (0.4.5.1 vs. 0.4.6.0)?

all of the props are misplaced

That sounds like a parsing issue.

@graysonk95

This comment has been minimized.

Show comment
Hide comment
@graysonk95

graysonk95 Apr 7, 2016

Are you able to reproduce the props misplacement every time you spawn that truck?
Yup, it's identical every time on every map.
My best guess is that it's an issue parsing the set_beam_defaults lines. It seems like the chassis itself is deformed at spawn more so than prop coordinates being improperly parsed/rounded.

Can you make two comparison screenshots (0.4.5.1 vs. 0.4.6.0)?
0.4.5.1
screenshot_654

0.4.6.0 RC3
screenshot_2016-04-07_10-00-45_1

graysonk95 commented Apr 7, 2016

Are you able to reproduce the props misplacement every time you spawn that truck?
Yup, it's identical every time on every map.
My best guess is that it's an issue parsing the set_beam_defaults lines. It seems like the chassis itself is deformed at spawn more so than prop coordinates being improperly parsed/rounded.

Can you make two comparison screenshots (0.4.5.1 vs. 0.4.6.0)?
0.4.5.1
screenshot_654

0.4.6.0 RC3
screenshot_2016-04-07_10-00-45_1

ulteq added a commit to ulteq/rigs-of-rods that referenced this issue Apr 20, 2016

@tritonas00

This comment has been minimized.

Show comment
Hide comment
@tritonas00

tritonas00 Apr 29, 2016

Collaborator

I can reproduce it easily if another vehicle is spawned first.

Load simple terrain and the HDX -> ok

Load simple terrain, a vehicle and then HDX -> this issue

Collaborator

tritonas00 commented Apr 29, 2016

I can reproduce it easily if another vehicle is spawned first.

Load simple terrain and the HDX -> ok

Load simple terrain, a vehicle and then HDX -> this issue

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Apr 30, 2016

Contributor

Ok, the bug was introduced by this commit: 88a5c91

Contributor

ulteq commented Apr 30, 2016

Ok, the bug was introduced by this commit: 88a5c91

@ulteq ulteq added this to the 0.4.6.0 milestone Apr 30, 2016

ulteq added a commit to ulteq/rigs-of-rods that referenced this issue May 1, 2016

ulteq added a commit to ulteq/rigs-of-rods that referenced this issue May 1, 2016

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq May 1, 2016

Contributor

This PR fixes the issue: #862

Contributor

ulteq commented May 1, 2016

This PR fixes the issue: #862

ulteq added a commit to ulteq/rigs-of-rods that referenced this issue May 1, 2016

[Codechange] Overworked the truck rotation during spawning
The translation and rotation of the truck nodes is no done after the RigSpawner is done

Fixes: RigsOfRods#820

@ulteq ulteq closed this in #866 May 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment