New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codechange] Suppress useless warnings in release mode #1015

Merged
merged 1 commit into from Jun 2, 2016

Conversation

Projects
None yet
2 participants
@ulteq
Contributor

ulteq commented Jun 1, 2016

Edit: Also adds -fno-omit-frame-pointer to RelWithDebInfo.

[Codechange] Suppress useless warnings in release mode
Disable -fomit-frame-pointer in RelWithDebInfo mode
@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jun 2, 2016

Contributor

I think -fno-omit-frame-pointer should stay in RelWithDebInfo for debugging purposes. It's probably included in most distributions' default CMAKE_CXX_FLAGS_RELWITHDEBINFO anyway.

Contributor

Hiradur commented Jun 2, 2016

I think -fno-omit-frame-pointer should stay in RelWithDebInfo for debugging purposes. It's probably included in most distributions' default CMAKE_CXX_FLAGS_RELWITHDEBINFO anyway.

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Jun 2, 2016

Contributor

This PR adds -fno-omit-frame-pointer to RelWithDebInfo.

Contributor

ulteq commented Jun 2, 2016

This PR adds -fno-omit-frame-pointer to RelWithDebInfo.

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jun 2, 2016

Contributor

oops, I read the diff the other way around 😊

EDIT: Probably because your PR message is misleading, it should've been "add fno-omit-frame-pointer to RelWithDebInfo" or something like that.

Contributor

Hiradur commented Jun 2, 2016

oops, I read the diff the other way around 😊

EDIT: Probably because your PR message is misleading, it should've been "add fno-omit-frame-pointer to RelWithDebInfo" or something like that.

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Jun 2, 2016

Contributor

Probably because your PR message is misleading

😊 I changed it.

Contributor

ulteq commented Jun 2, 2016

Probably because your PR message is misleading

😊 I changed it.

@ulteq ulteq merged commit 98cce2b into RigsOfRods:master Jun 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq removed the needs discussion label Jun 2, 2016

@ulteq ulteq deleted the ulteq:unix-build-flag-proposal branch Jun 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment