[Fix] Fixed vehicle info not fitting in the info box #1075

Merged
merged 1 commit into from Sep 13, 2016

Projects

None yet

4 participants

@AnotherFoxGuy
Contributor

Fixes #1068

screenshot_2016-07-14_12-47-06_2

@Hiradur Hiradur commented on an outdated diff Jul 14, 2016
tools/linux/l10n/from_transifex.sh
@@ -13,4 +13,6 @@ do
echo "Now copying $file"
mkdir -p ../../../languages/$file/LC_MESSAGES/
cp $file.po ../../../languages/$file/LC_MESSAGES/ror.po
+ cp ../../../SourceSansPro-Regular.ttf ../../../languages/$file/LC_MESSAGES/SourceSansPro-Regular.ttf
@Hiradur
Hiradur Jul 14, 2016 Contributor

This seems inefficient to me, can't you just put it in the resources folder?

@Hiradur Hiradur commented on an outdated diff Jul 14, 2016
tools/linux/l10n/SourceSansPro-License.txt
@@ -0,0 +1,91 @@
+Copyright (c) 2010, Adobe Systems, Inc. (http://www.adobe.com/)
@Hiradur
Hiradur Jul 14, 2016 edited Contributor

This whole text file should be appended to DEPENDENCIES.md

@Hiradur
Contributor
Hiradur commented Jul 15, 2016

It's good but having to copy the MyGUI_FontConfig.xml file to every language folder still seems to be inefficient. Why aren't we using SourceSansPro-Regular.ttf fo English as well so one MyGUI_FontConfig.xml file in the bin/resources/mygui folder should be enough?
One issue with SourceSansPro is that it's rather limited. As far as I can tell it doesn't have e.g. kyrillic, arabic or asian characters. IMO GNU Unifont would be a good choice as a "one for all" font. Also see #450

@only-a-ptr only-a-ptr added this to the 0.4.7.0 milestone Aug 30, 2016
@only-a-ptr only-a-ptr self-assigned this Aug 30, 2016
@ulteq
Contributor
ulteq commented Sep 11, 2016

@AnotherFoxGuy, can you comment on what @Hiradur said?

@AnotherFoxGuy AnotherFoxGuy [Fix] Fixed vehicle info not fitting in the info box
Fixes #1068
b21c959
@AnotherFoxGuy
Contributor
AnotherFoxGuy commented Sep 11, 2016 edited

Why aren't we using SourceSansPro-Regular.ttf fo English as well so one MyGUI_FontConfig.xml file in the bin/resources/mygui folder should be enough?

I've moved SourceSansPro-Regular.ttf and MyGUI_FontConfig.xml to the resources folder.

Edit: it seems that Travis is broken?

@ulteq
Contributor
ulteq commented Sep 13, 2016

Edit: it seems that Travis is broken?

Nah, it works now.

@ulteq ulteq merged commit 3320200 into RigsOfRods:master Sep 13, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@AnotherFoxGuy AnotherFoxGuy deleted the unknown repository branch Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment