New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fixes videocamera stuttering #1116

Merged
merged 1 commit into from Sep 13, 2016

Conversation

Projects
None yet
2 participants
@ulteq
Contributor

ulteq commented Sep 10, 2016

Related with: #1109

@ulteq ulteq merged commit 2cedd09 into RigsOfRods:master Sep 13, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Sep 13, 2016

Member

Definitely a better way to do it, but this will make the reflected image 1 frame out of date. Not a big deal, but may be noticed under lower FPS.

IMO the call to updateVideocameras() should be done a lot later, somewhere around the end of frameStarted()

Member

only-a-ptr commented Sep 13, 2016

Definitely a better way to do it, but this will make the reflected image 1 frame out of date. Not a big deal, but may be noticed under lower FPS.

IMO the call to updateVideocameras() should be done a lot later, somewhere around the end of frameStarted()

@ulteq ulteq deleted the ulteq:videocamera_stuttering_fix branch Sep 13, 2016

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Sep 13, 2016

Contributor

I just reverted it to how it was: https://github.com/only-a-ptr/ror-legacy-svn-trunk/blob/0a55a993899d6a06cdc58fd98b5b675b371eb89a/source/main/gameplay/RoRFrameListener.cpp#L3135

this will make the reflected image 1 frame out of date

I don't think so. But I'm not sure about it.

Contributor

ulteq commented Sep 13, 2016

I just reverted it to how it was: https://github.com/only-a-ptr/ror-legacy-svn-trunk/blob/0a55a993899d6a06cdc58fd98b5b675b371eb89a/source/main/gameplay/RoRFrameListener.cpp#L3135

this will make the reflected image 1 frame out of date

I don't think so. But I'm not sure about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment