New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Simplifies creation of visual beams #1120

Merged
merged 3 commits into from Oct 7, 2016

Conversation

Projects
None yet
2 participants
@ulteq
Contributor

ulteq commented Sep 13, 2016

Fixes visual glitch when ties become visible

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Sep 13, 2016

Member

Hmmm... I like this change a lot, but I'm worried it will introduce some weird visibility glitch elsewhere. Or crash RoR at some unexpected point.

I've put the logic in there because 0.38x did it that way. IDK why, I've been putting //wtf comments around it since I came.

This needs extra testing with variety of vehicles and scenarios (attaching/detaching loads etc...)

Member

only-a-ptr commented Sep 13, 2016

Hmmm... I like this change a lot, but I'm worried it will introduce some weird visibility glitch elsewhere. Or crash RoR at some unexpected point.

I've put the logic in there because 0.38x did it that way. IDK why, I've been putting //wtf comments around it since I came.

This needs extra testing with variety of vehicles and scenarios (attaching/detaching loads etc...)

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Sep 13, 2016

Contributor

This needs extra testing with variety of vehicles and scenarios

Agreed.

Contributor

ulteq commented Sep 13, 2016

This needs extra testing with variety of vehicles and scenarios

Agreed.

@ulteq ulteq added this to the 0.4.7.0 milestone Sep 15, 2016

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Oct 6, 2016

Member

👍

Member

only-a-ptr commented Oct 6, 2016

👍

@ulteq ulteq merged commit 03f7ec8 into RigsOfRods:master Oct 7, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:simplified_visual_beam_creation branch Oct 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment