New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Minor cleanup in various places #1158

Merged
merged 5 commits into from Oct 16, 2016

Conversation

Projects
None yet
2 participants
@ulteq
Contributor

ulteq commented Oct 15, 2016

No description provided.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Oct 15, 2016

Member

For some reason GitHub won't let me comment on commits anymore...

c787b9d
DofManager should be moved under CameraManager. It's the only class which ever accesses it. There's absolutely no reason why to have it in gEnv.
Besides, I'd like to remove gEnv completely. we have App namespace now. However, I'd like to minimize the amount of global objects there, too. Most of the time, they only need to be global because the code is badly designed and accesses them from places it shouldn't

Member

only-a-ptr commented Oct 15, 2016

For some reason GitHub won't let me comment on commits anymore...

c787b9d
DofManager should be moved under CameraManager. It's the only class which ever accesses it. There's absolutely no reason why to have it in gEnv.
Besides, I'd like to remove gEnv completely. we have App namespace now. However, I'd like to minimize the amount of global objects there, too. Most of the time, they only need to be global because the code is badly designed and accesses them from places it shouldn't

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Oct 16, 2016

Contributor

DofManager should be moved under CameraManager.

Agreed.

Contributor

ulteq commented Oct 16, 2016

DofManager should be moved under CameraManager.

Agreed.

@ulteq ulteq merged commit ab93644 into RigsOfRods:master Oct 16, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:minor-cleanup branch Oct 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment