New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Fixes warning 'C4715' #1166

Merged
merged 1 commit into from Oct 17, 2016

Conversation

Projects
None yet
2 participants
@ulteq
Contributor

ulteq commented Oct 16, 2016

Also fixes some code formatting inconsistencies

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Oct 16, 2016

Member

You left one inconsistency: missing newline between int func() and {
Anyway, was this really an inconsistency? All enum->str functions were written that way. I thought it was a clever domain-specific style.

I'm for using specific formatting where it's handy.

Member

only-a-ptr commented Oct 16, 2016

You left one inconsistency: missing newline between int func() and {
Anyway, was this really an inconsistency? All enum->str functions were written that way. I thought it was a clever domain-specific style.

I'm for using specific formatting where it's handy.

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Oct 17, 2016

Contributor

Anyway, was this really an inconsistency?

The only reason I touched the code were the 'C4715 warnings.

I thought it was a clever domain-specific style.

I don't think we should start introducing any more styles.

You left one inconsistency: missing newline between int func() and {

Agreed, I will change it.

Contributor

ulteq commented Oct 17, 2016

Anyway, was this really an inconsistency?

The only reason I touched the code were the 'C4715 warnings.

I thought it was a clever domain-specific style.

I don't think we should start introducing any more styles.

You left one inconsistency: missing newline between int func() and {

Agreed, I will change it.

@ulteq ulteq merged commit 50d9882 into RigsOfRods:master Oct 17, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:warning-fixes branch Oct 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment