New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fixes 'FOV' setting #1192

Merged
merged 1 commit into from Oct 19, 2016

Conversation

Projects
None yet
2 participants
@ulteq
Contributor

ulteq commented Oct 19, 2016

Makes 'FOV External' and 'FOV Internal' plain cvars.

Related with: #1163

[Bugfix] Fixes 'FOV' setting
Makes 'FOV External' and 'FOV Internal' plain cvars

@ulteq ulteq added this to the 0.4.7.0 milestone Oct 19, 2016

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Oct 19, 2016

Member

I'm already working on a generic solution for this: https://github.com/only-a-ptr/rigs-of-rods/blob/gvars-3s/source/main/Application.h#L37-L54; branch: https://github.com/only-a-ptr/rigs-of-rods/tree/gvars-3s

EDIT: Oh, right, I forgot to drop you a note... It turned out there are more gvars which need to retain config setting: #1163 (comment)
So I decided to create a generic solution afterall. I also generalized the mechanism of "pending" value used in App/Mp/Sim states and likely to be useful elsewhere.

Member

only-a-ptr commented Oct 19, 2016

I'm already working on a generic solution for this: https://github.com/only-a-ptr/rigs-of-rods/blob/gvars-3s/source/main/Application.h#L37-L54; branch: https://github.com/only-a-ptr/rigs-of-rods/tree/gvars-3s

EDIT: Oh, right, I forgot to drop you a note... It turned out there are more gvars which need to retain config setting: #1163 (comment)
So I decided to create a generic solution afterall. I also generalized the mechanism of "pending" value used in App/Mp/Sim states and likely to be useful elsewhere.

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Oct 19, 2016

Contributor

I like your generic solution, but i still think this should be merged first.

I'm already working on a generic solution for this

Will it be ready for 0.4.7.0?

It turned out there are more gvars which need to retain config setting

The preselected settings are supposed to be read-only.

Contributor

ulteq commented Oct 19, 2016

I like your generic solution, but i still think this should be merged first.

I'm already working on a generic solution for this

Will it be ready for 0.4.7.0?

It turned out there are more gvars which need to retain config setting

The preselected settings are supposed to be read-only.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Oct 19, 2016

Member

I like your generic solution, but i still think this should be merged first.

Agreed :shipit:

Member

only-a-ptr commented Oct 19, 2016

I like your generic solution, but i still think this should be merged first.

Agreed :shipit:

@ulteq ulteq merged commit b736b25 into RigsOfRods:master Oct 19, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:fov-setting-fix branch Oct 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment