New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fixes conflict between animators and hydros #1199

Merged
merged 1 commit into from Oct 21, 2016

Conversation

Projects
None yet
2 participants
@ulteq
Contributor

ulteq commented Oct 20, 2016

The steering wheel rotation angle (hydrodirwheeldisplay) must not be affected by animators.

Fixes: #1100

[Bugfix] Fixes conflict between animators and hydros
The steering wheel rotation angle (hydrodirwheeldisplay) must not be affected by animators

Fixes: 1100

@ulteq ulteq added this to the 0.4.7.0 milestone Oct 20, 2016

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Oct 20, 2016

Member

👍 You did it!

Member

only-a-ptr commented Oct 20, 2016

👍 You did it!

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Oct 21, 2016

Contributor

Yeah, but what I don't understand:

There were no problems with the steering wheel in 0.39.5 and 0.4.0.7 (the versions I have installed atm) with this animator line.

This line of code is very old: https://github.com/only-a-ptr/ror-legacy-svn-trunk/blob/master/source/main/physics/BeamForcesEuler.cpp#L1708-L1709

The issue must have been hidden by a different control flow in previous versions.

I suspected this commit: ef3b529, but reverting it did not fix the bug.

Contributor

ulteq commented Oct 21, 2016

Yeah, but what I don't understand:

There were no problems with the steering wheel in 0.39.5 and 0.4.0.7 (the versions I have installed atm) with this animator line.

This line of code is very old: https://github.com/only-a-ptr/ror-legacy-svn-trunk/blob/master/source/main/physics/BeamForcesEuler.cpp#L1708-L1709

The issue must have been hidden by a different control flow in previous versions.

I suspected this commit: ef3b529, but reverting it did not fix the bug.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Oct 21, 2016

Member

Yeah, but what I don't understand

Strange, but RoR is still mysterious. Might as well be multithreading - traction/handling stuff is done half mainthread half simthreads. I don't recall exactly where are the collision surfaces, but I do remember how my scripted engine sim blew everything up.

Member

only-a-ptr commented Oct 21, 2016

Yeah, but what I don't understand

Strange, but RoR is still mysterious. Might as well be multithreading - traction/handling stuff is done half mainthread half simthreads. I don't recall exactly where are the collision surfaces, but I do remember how my scripted engine sim blew everything up.

@ulteq ulteq merged commit bb74234 into RigsOfRods:master Oct 21, 2016

2 of 3 checks passed

codacy/pr Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:steering-wheel-animation-fix branch Oct 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment