New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP serverlist GUI now fully functional #1204

Merged
merged 1 commit into from Oct 23, 2016

Conversation

Projects
None yet
3 participants
@only-a-ptr
Member

only-a-ptr commented Oct 21, 2016

ror-serverlist-yay

It all works!

Fixes #1193

@only-a-ptr only-a-ptr added this to the 0.4.7.0 milestone Oct 21, 2016

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Oct 21, 2016

Contributor

Do we really need to add almost 10.000 lines for this?

Only manual refreshing works.

I think that's just fine. I don't see the purpose of auto refreshing.

Contributor

ulteq commented Oct 21, 2016

Do we really need to add almost 10.000 lines for this?

Only manual refreshing works.

I think that's just fine. I don't see the purpose of auto refreshing.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Oct 21, 2016

Member

Do we really need to add almost 10.000 lines for this?

Most of that is JsonCpp library and the cloned/patched MyGUI::MultiListBox. EDIT: removed that. But it's a bad number indeed.

I think that's just fine. I don't see the purpose of auto refreshing

I meant it doesn't auto-update when opened. I also don't think we need periodic auto-refresh.

Member

only-a-ptr commented Oct 21, 2016

Do we really need to add almost 10.000 lines for this?

Most of that is JsonCpp library and the cloned/patched MyGUI::MultiListBox. EDIT: removed that. But it's a bad number indeed.

I think that's just fine. I don't see the purpose of auto refreshing

I meant it doesn't auto-update when opened. I also don't think we need periodic auto-refresh.

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Oct 21, 2016

Contributor

I meant it doesn't auto-update when opened.

Ok, that should be changed.

Contributor

ulteq commented Oct 21, 2016

I meant it doesn't auto-update when opened.

Ok, that should be changed.

@only-a-ptr only-a-ptr changed the title from [Add] MP serverlist GUI now loads to {{WIP!!}} [Add] MP serverlist GUI now loads Oct 21, 2016

@only-a-ptr only-a-ptr changed the title from {{WIP!!}} [Add] MP serverlist GUI now loads to <Ready!> MP serverlist GUI now loads Oct 23, 2016

@only-a-ptr only-a-ptr changed the title from <Ready!> MP serverlist GUI now loads to <Ready!> MP serverlist GUI now fully functional Oct 23, 2016

@tritonas00

This comment has been minimized.

Show comment
Hide comment
@tritonas00

tritonas00 Oct 23, 2016

Collaborator

Great, but this PR is extremely linux unfriendly to compile

https://paste.ee/p/yEQ7s

Collaborator

tritonas00 commented Oct 23, 2016

Great, but this PR is extremely linux unfriendly to compile

https://paste.ee/p/yEQ7s

Show outdated Hide outdated source/main/utils/Utils.cpp Outdated
Show outdated Hide outdated source/main/gui/panels/GUI_MultiplayerSelector.cpp Outdated
@@ -45,6 +45,10 @@ using namespace Ogre;
#include "ShellAPI.h"
#endif //OGRE_PLATFORM_WIN32
#ifdef USE_CURL
# include <curl/curl.h>
#endif //USE_CURL

This comment has been minimized.

@ulteq

ulteq Oct 23, 2016

Contributor

Do we need include <stdio.h> here?

@ulteq

ulteq Oct 23, 2016

Contributor

Do we need include <stdio.h> here?

This comment has been minimized.

@only-a-ptr

only-a-ptr Oct 23, 2016

Member

I don't know. But older includes of curl.h were always coupled with stdio.h

@only-a-ptr

only-a-ptr Oct 23, 2016

Member

I don't know. But older includes of curl.h were always coupled with stdio.h

Show outdated Hide outdated source/main/CMakeLists.txt Outdated

@only-a-ptr only-a-ptr changed the title from <Ready!> MP serverlist GUI now fully functional to MP serverlist GUI now fully functional Oct 23, 2016

[Add] MP serverlist GUI now fully functional
Added library JsonCpp into RoR source tree (move to dependencies later!)
@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Oct 23, 2016

Member

@ulteq I squashed your build fix and CMake alphabetic cleanup

Member

only-a-ptr commented Oct 23, 2016

@ulteq I squashed your build fix and CMake alphabetic cleanup

@tritonas00

This comment has been minimized.

Show comment
Hide comment
@tritonas00

tritonas00 Oct 23, 2016

Collaborator

Now compiles and works fine :)

Collaborator

tritonas00 commented Oct 23, 2016

Now compiles and works fine :)

@ulteq

ulteq approved these changes Oct 23, 2016

@only-a-ptr only-a-ptr merged commit 9639b8b into RigsOfRods:master Oct 23, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment