New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fixes game crash on invalid forset line #1205

Merged
merged 1 commit into from Oct 22, 2016

Conversation

Projects
None yet
3 participants
@ulteq
Contributor

ulteq commented Oct 22, 2016

This only hides the underlying issue.

Fixes: #1058

@AnotherFoxGuy

This comment has been minimized.

Show comment
Hide comment
@AnotherFoxGuy

AnotherFoxGuy Oct 22, 2016

Member

👍 This fixes the crash on windows

Member

AnotherFoxGuy commented Oct 22, 2016

👍 This fixes the crash on windows

@AnotherFoxGuy AnotherFoxGuy added this to the 0.4.7.0 milestone Oct 22, 2016

@ulteq ulteq merged commit c5c4fd9 into RigsOfRods:master Oct 22, 2016

3 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Oct 22, 2016

Member

This only hides the underlying issue.

If that's so, pls comment it in the code. I guess this avoids the "Flexbody: node ABCD whatever not found" issue, but I don't know exactly

Member

only-a-ptr commented Oct 22, 2016

This only hides the underlying issue.

If that's so, pls comment it in the code. I guess this avoids the "Flexbody: node ABCD whatever not found" issue, but I don't know exactly

@ulteq ulteq deleted the ulteq:forset-hotfix branch Oct 22, 2016

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Oct 22, 2016

Contributor

I guess this avoids the "Flexbody: node ABCD whatever not found"

It only avoids a crash to desktop

This only hides the underlying issue.

The bug is still obvious in the code. Only players won't notice it immediately.

This only prevents out of bound array accesses.

Contributor

ulteq commented Oct 22, 2016

I guess this avoids the "Flexbody: node ABCD whatever not found"

It only avoids a crash to desktop

This only hides the underlying issue.

The bug is still obvious in the code. Only players won't notice it immediately.

This only prevents out of bound array accesses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment