New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] 45000% faster truckfile parsing #1233

Merged
merged 2 commits into from Nov 1, 2016

Conversation

Projects
None yet
5 participants
@only-a-ptr
Member

only-a-ptr commented Oct 31, 2016

Regexes aren't evil or dangerous, except if the programmer is an idiot 馃槉

Attached is a benchmark with a README introducing a new perf. guideline.

[Fix] 45000% faster truckfile parsing
Regexes aren't evil or dangerous, except if the programmer is an idiot.

Attached is a benchmark with a README introducing a new perf. guideline.

@only-a-ptr only-a-ptr added this to the 0.4.7.0 milestone Oct 31, 2016

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Nov 1, 2016

Contributor

Truckfile parsing on big truck files is now 15 times faster on my machine. 馃憤

Full cache regeneration with ~370 mods (both terrains and trucks):
Before: 47 seconds
After: 19 seconds

Contributor

ulteq commented Nov 1, 2016

Truckfile parsing on big truck files is now 15 times faster on my machine. 馃憤

Full cache regeneration with ~370 mods (both terrains and trucks):
Before: 47 seconds
After: 19 seconds

@Speciesx

This comment has been minimized.

Show comment
Hide comment
@Speciesx

Speciesx Nov 1, 2016

Contributor

72 terrains + 447 trucks.

Before: 130 seconds
After: 28 seconds

Contributor

Speciesx commented Nov 1, 2016

72 terrains + 447 trucks.

Before: 130 seconds
After: 28 seconds

@only-a-ptr only-a-ptr merged commit fecbb3a into RigsOfRods:master Nov 1, 2016

3 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@only-a-ptr only-a-ptr deleted the only-a-ptr:faster-truck-parsing branch Nov 1, 2016

@tritonas00

This comment has been minimized.

Show comment
Hide comment
@tritonas00

tritonas00 Nov 1, 2016

Collaborator

322 mods

Before: 27 seconds
After: 15 seconds

Yes, everything spawns a lot faster, almost immediately 馃槃 馃憤

Collaborator

tritonas00 commented Nov 1, 2016

322 mods

Before: 27 seconds
After: 15 seconds

Yes, everything spawns a lot faster, almost immediately 馃槃 馃憤

@disloyalpick

This comment has been minimized.

Show comment
Hide comment
@disloyalpick

disloyalpick Nov 1, 2016

Very much faster on my linux install. Going back to Windows to test. Haven't used linux lately due to RoR not using my Nvidia GPU. And having no idea how to make it do that. Lol.

disloyalpick commented Nov 1, 2016

Very much faster on my linux install. Going back to Windows to test. Haven't used linux lately due to RoR not using my Nvidia GPU. And having no idea how to make it do that. Lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment