New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled "Allow DirectX9Ex" setting #1243

Merged
merged 1 commit into from Nov 15, 2016

Conversation

Projects
None yet
2 participants
@AnotherFoxGuy
Member

AnotherFoxGuy commented Nov 15, 2016

Fixes #1239

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 15, 2016

Member

Nice.

Could you also remove the checkbox from RoRConfig altogether? Since we'll port to OGRE 2.1 in foreseeable future, we won't ever need it again. Removing it is just a matter of finding the widget setup code (the GUI is fully created in code) and removing it.

Member

only-a-ptr commented Nov 15, 2016

Nice.

Could you also remove the checkbox from RoRConfig altogether? Since we'll port to OGRE 2.1 in foreseeable future, we won't ever need it again. Removing it is just a matter of finding the widget setup code (the GUI is fully created in code) and removing it.

@AnotherFoxGuy

This comment has been minimized.

Show comment
Hide comment
@AnotherFoxGuy

AnotherFoxGuy Nov 15, 2016

Member

Which checkbox do you mean?

Member

AnotherFoxGuy commented Nov 15, 2016

Which checkbox do you mean?

@AnotherFoxGuy AnotherFoxGuy merged commit 5b49118 into RigsOfRods:master Nov 15, 2016

3 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@AnotherFoxGuy AnotherFoxGuy deleted the AnotherFoxGuy:dx9ex-fix branch Nov 15, 2016

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 15, 2016

Member

@AnotherFoxGuy Ignore that, I was confused. I thought there was a checkbox for this, but it's actually one of the optional droplists under "Render System" tab: https://forum.rigsofrods.org/thread-697-post-6546.html#pid6546

Does the "Allow Dx9Ex" option appear for you? If yes, can you block it from appearing in the options? The loop which generates the option droplists is here: https://github.com/RigsOfRods/rigs-of-rods/blob/master/source/configurator/Configurator.cpp#L1814-L1980 You can tell the option by it's name: https://github.com/RigsOfRods/rigs-of-rods/blob/master/source/configurator/Configurator.cpp#L1869

Member

only-a-ptr commented Nov 15, 2016

@AnotherFoxGuy Ignore that, I was confused. I thought there was a checkbox for this, but it's actually one of the optional droplists under "Render System" tab: https://forum.rigsofrods.org/thread-697-post-6546.html#pid6546

Does the "Allow Dx9Ex" option appear for you? If yes, can you block it from appearing in the options? The loop which generates the option droplists is here: https://github.com/RigsOfRods/rigs-of-rods/blob/master/source/configurator/Configurator.cpp#L1814-L1980 You can tell the option by it's name: https://github.com/RigsOfRods/rigs-of-rods/blob/master/source/configurator/Configurator.cpp#L1869

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment