New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #463

Merged
merged 13 commits into from Dec 3, 2015

Conversation

Projects
None yet
2 participants
@Hiradur
Contributor

Hiradur commented Dec 1, 2015

No description provided.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Nov 24, 2015

Looks good.

I can't judge the impact because I don't know how it behaved and should behave. I try not to touch this area because the code is apparently fragile and the functionality is highly exposed to players.

I wanted to check agains RoR 0.38, but the code is a mess: https://github.com/only-a-ptr/ror-legacy-svn-trunk/blob/db0b4b922c0eb8de240ac720edbc3560e5cd1399/source/main/gameplay/RoRFrameListener.cpp#L2509
The link is from v 0.38.66 only-a-ptr/ror-legacy-svn-trunk@db0b4b9

only-a-ptr commented on 97a9aa0 Nov 24, 2015

Looks good.

I can't judge the impact because I don't know how it behaved and should behave. I try not to touch this area because the code is apparently fragile and the functionality is highly exposed to players.

I wanted to check agains RoR 0.38, but the code is a mess: https://github.com/only-a-ptr/ror-legacy-svn-trunk/blob/db0b4b922c0eb8de240ac720edbc3560e5cd1399/source/main/gameplay/RoRFrameListener.cpp#L2509
The link is from v 0.38.66 only-a-ptr/ror-legacy-svn-trunk@db0b4b9

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Nov 24, 2015

Owner

To be honest I didn't look at 0.38's code and instead just started the game and observed how it behaves. I also think that the code for shifting is unnecessarily complex (I saw some redundant if clauses in particular) but never touch a running system ;)

The statements I eliminated prevented that you could downshift into N or R (you were forced to use the shift_neutral or shift_reverse key instead) and upshift from N and R in automatic mode which may be more realistic but is an unnecessary restriction for RoR IMO.

Owner

Hiradur replied Nov 24, 2015

To be honest I didn't look at 0.38's code and instead just started the game and observed how it behaves. I also think that the code for shifting is unnecessarily complex (I saw some redundant if clauses in particular) but never touch a running system ;)

The statements I eliminated prevented that you could downshift into N or R (you were forced to use the shift_neutral or shift_reverse key instead) and upshift from N and R in automatic mode which may be more realistic but is an unnecessary restriction for RoR IMO.

@Hiradur Hiradur added this to the 0.4.6.0 milestone Dec 2, 2015

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr commented on 0bd3c49 Dec 3, 2015

👍

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Dec 3, 2015

Owner

@only-a-ptr It's untested though 😊
I hope I can test it within a few weeks.

Owner

Hiradur replied Dec 3, 2015

@only-a-ptr It's untested though 😊
I hope I can test it within a few weeks.

only-a-ptr added a commit that referenced this pull request Dec 3, 2015

@only-a-ptr only-a-ptr merged commit 9535c19 into RigsOfRods:master Dec 3, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Dec 3, 2015

Member

Good work

Member

only-a-ptr commented Dec 3, 2015

Good work

@Hiradur Hiradur deleted the Hiradur:bugfixes branch Jan 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment