New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] BeamForcesEuler, BeamFactory, Beam #486

Merged
merged 8 commits into from Dec 20, 2015

Conversation

Projects
None yet
3 participants
@ulteq
Contributor

ulteq commented Dec 18, 2015

BeamForcesEuler and Sim-Core struct cleanup:

  • Removed unused variables in the Sim-Core structs (lastforce, minendmass, lastNormal)
  • Removed the inverted_mass variable in the node_t struct (now calculated on demand)
  • Removed duplicate code in BeamForcesEuler (bounding box code)
  • Removed all experimental (and unused) INTRA_TRUCK_PARALLEL related code

Beam and BeamFactory cleanup:

  • Skeleton view cleanup
  • Removed the beamThreadPool in favor of the gEnv->threadPool
@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr commented on b23532e Dec 9, 2015

👍

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Dec 9, 2015

Member

👍

Member

only-a-ptr commented on b23532e Dec 9, 2015

👍

[Cleanup] Removed more dead code
* Removed unused variables in the Sim-Core structs

* Removed duplicate code in BeamForcesEuler
@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Dec 11, 2015

bb should be a &reference,right? Now you're modifying copies

bb should be a &reference,right? Now you're modifying copies

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Dec 18, 2015

Contributor

👍

Contributor

Hiradur commented Dec 18, 2015

👍

@ulteq ulteq changed the title from BeamForcesEuler Cleanup to [Cleanup] BeamForcesEuler, BeamFactory, Beam Dec 19, 2015

only-a-ptr added a commit that referenced this pull request Dec 20, 2015

Merge pull request #486 from ulteq/BeamForcesEulerCleanup
[Cleanup] BeamForcesEuler, BeamFactory, Beam

@only-a-ptr only-a-ptr merged commit 9e129aa into RigsOfRods:master Dec 20, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:BeamForcesEulerCleanup branch Dec 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment