New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] nullptr dereferencing in calcAnimators #512

Merged
merged 2 commits into from Jan 4, 2016

Conversation

Projects
None yet
2 participants
@ulteq
Contributor

ulteq commented Dec 30, 2015

Fixes #501

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Dec 29, 2015

Umm, shouldn't the engine-dependent animations be just skipped when there's no engine?

I mean:

if ( (flag_state & ANIM_FLAG_CLUTCH) && engine != nullptr)

Also, what does the div++; mean?

only-a-ptr commented on a51d80a Dec 29, 2015

Umm, shouldn't the engine-dependent animations be just skipped when there's no engine?

I mean:

if ( (flag_state & ANIM_FLAG_CLUTCH) && engine != nullptr)

Also, what does the div++; mean?

@ulteq ulteq closed this Dec 30, 2015

@ulteq ulteq reopened this Dec 30, 2015

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Dec 30, 2015

Contributor

Umm, shouldn't the engine-dependent animations be just skipped when there's no engine?

Agreed, I've changed it.

Contributor

ulteq commented Dec 30, 2015

Umm, shouldn't the engine-dependent animations be just skipped when there's no engine?

Agreed, I've changed it.

only-a-ptr added a commit that referenced this pull request Jan 4, 2016

Merge pull request #512 from ulteq/calcAnimatorsFix
[Bugfix] nullptr dereferencing in calcAnimators

@only-a-ptr only-a-ptr merged commit 7f3d078 into RigsOfRods:master Jan 4, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:calcAnimatorsFix branch Jan 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment