New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Build without Angelscript #537

Merged
merged 1 commit into from Jan 9, 2016

Conversation

Projects
None yet
2 participants
@Hiradur
Contributor

Hiradur commented Jan 7, 2016

  • Fixes compiler errors when building without Angelscript (#534)
  • Additionally, to avoid crashing when loading terrains, in resources/particles/water.particle this needs to be removed:
    affector FireExtinguisher
    {
        effectiveness   1
    }

Hiradur added a commit that referenced this pull request Jan 9, 2016

Merge pull request #537 from Hiradur/as_fix
[Fix] Build without Angelscript

@Hiradur Hiradur merged commit ef0b898 into RigsOfRods:master Jan 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Hubbitus

This comment has been minimized.

Show comment
Hide comment
@Hubbitus

Hubbitus Jan 10, 2016

It should be removed on build time only when building without angelscript? Why it does not touched in your commit?

Hubbitus commented Jan 10, 2016

It should be removed on build time only when building without angelscript? Why it does not touched in your commit?

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 10, 2016

Contributor

It should be removed on build time only when building without angelscript? Why it does not touched in your commit?

Not sure how to do this since it's a custom file format used by Ogre, missing e.g. pre-processor macros

Contributor

Hiradur commented Jan 10, 2016

It should be removed on build time only when building without angelscript? Why it does not touched in your commit?

Not sure how to do this since it's a custom file format used by Ogre, missing e.g. pre-processor macros

@Hubbitus

This comment has been minimized.

Show comment
Hide comment
@Hubbitus

Hubbitus Jan 10, 2016

No-no. I ask it can't be deleted and commited? It should be deleted only when angelscript disabled (and then require some scripting)?

Hubbitus commented Jan 10, 2016

No-no. I ask it can't be deleted and commited? It should be deleted only when angelscript disabled (and then require some scripting)?

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 10, 2016

Contributor

No-no. I ask it can't be deleted and commited? It should be deleted only when angelscript disabled (and then require some scripting)?

Maybe CMake could do that but I wouldn't know how. Research in that area would be welcome.

Contributor

Hiradur commented Jan 10, 2016

No-no. I ask it can't be deleted and commited? It should be deleted only when angelscript disabled (and then require some scripting)?

Maybe CMake could do that but I wouldn't know how. Research in that area would be welcome.

@Hubbitus

This comment has been minimized.

Show comment
Hide comment
@Hubbitus

Hubbitus Jan 10, 2016

In other words, that's lines needed if angelscript support enabled?

Hubbitus commented Jan 10, 2016

In other words, that's lines needed if angelscript support enabled?

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 10, 2016

Contributor

In other words, that's lines needed if angelscript support enabled?

Probably not but a graphical effect would be missing.

Contributor

Hiradur commented Jan 10, 2016

In other words, that's lines needed if angelscript support enabled?

Probably not but a graphical effect would be missing.

@Hubbitus

This comment has been minimized.

Show comment
Hide comment
@Hubbitus

Hubbitus Jan 12, 2016

Thanks for the explanation.

Hubbitus commented Jan 12, 2016

Thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment