New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyGUI API changes to use getValue in 3.2.1. #547

Merged
merged 1 commit into from Jan 9, 2016

Conversation

Projects
None yet
2 participants
@jeremybennett

jeremybennett commented Jan 9, 2016

RoR master will not build out of the box on Fedora 23.

Steps to reproduce

  1. Install MyGUI from the official repositories on Fedora 23. This is MyGUI 3.2.1.
  2. Follow the steps to build for Fedora on http://www.rigsofrods.com/wiki/pages/Compiling_Sources_under_Linux, using Fedora 23

Expected behaviour

RoR should build

Actual behaviour

RoR fails, due to defining MYGUI_GET_SCANCODE(KEY) to be KEY.toValue(), rather than KEY.getValue()

System configuration

Fedora 23 64bit with Radeon R9 R390 and default open source device driver. Output of uname -a:

Linux wotan.home.gateway 4.2.8-300.fc23.x86_64 #1 SMP Tue Dec 15 16:49:06 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

Additional information, logs and screenshots (optional)

Patch provided here. ChangeLog record

* source/main/RoRPrerequisites.h: Definition for MYGUI_GET_SCANCODE
should change on version 3.2.1.

Note. A number of further changes are needed to complete the compilation under Fedora. Further patches to follow:

Jeremy Bennett
MyGUI API changes to use getValue in 3.2.1.
	* source/main/RoRPrerequisites.h: Definition for MYGUI_GET_SCANCODE
	should change on version 3.2.1. This happens to be the version
	distributed with Fedora 23, which exposes this issue.
@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 9, 2016

Contributor

Thanks! MyGUI 3.2.1 wasn't tested apparently.

Contributor

Hiradur commented Jan 9, 2016

Thanks! MyGUI 3.2.1 wasn't tested apparently.

Hiradur added a commit that referenced this pull request Jan 9, 2016

Merge pull request #547 from jeremybennett/mygui-version
MyGUI API changes to use getValue in 3.2.1.

@Hiradur Hiradur merged commit f0d6b66 into RigsOfRods:master Jan 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Hiradur Hiradur referenced this pull request Jan 17, 2016

Closed

MyGUI 3.2.2 not supported #156

Hubbitus added a commit to Hubbitus/Fedora-packaging that referenced this pull request Jan 25, 2016

0.4.6.0-0.6.git.3e56c07
- Issue with compilation on ARM resolved (RigsOfRods/rigs-of-rods#608).
- Drop rigsofrods-0.4.6.0-mygui-gt-2.2.1.patch as it incorporated (RigsOfRods/rigs-of-rods#156 -> RigsOfRods/rigs-of-rods#547)

Hubbitus added a commit to Hubbitus/rpm-rigsofrods that referenced this pull request Jan 31, 2017

0.4.6.0-0.6.git.3e56c07
- Issue with compilation on ARM resolved (RigsOfRods/rigs-of-rods#608).
- Drop rigsofrods-0.4.6.0-mygui-gt-2.2.1.patch as it incorporated (RigsOfRods/rigs-of-rods#156 -> RigsOfRods/rigs-of-rods#547)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment