New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codechange] Clearing out and reordering of the node_t members #557

Merged
merged 1 commit into from Jan 15, 2016

Conversation

Projects
None yet
3 participants
@ulteq
Contributor

ulteq commented Jan 11, 2016

Before: sizeof(node_t) = 240
After: sizeof(node_t) = 128

All frequently accessed data is within the first 64 Bytes of the struct.

[Codechange] Clearing out and reordering of the node_t members
* The new struct is 128 Bytes small

* Frequently accessed data is within the first 64 Bytes of the struct
@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 12, 2016

was step&7 a typo here?

was step&7 a typo here?

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 12, 2016

Can this be removed?

Hiradur commented on source/main/physics/water/Buoyance.cpp in e2746ef Jan 12, 2016

Can this be removed?

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Jan 12, 2016

Contributor

was step&7 a typo here?

No, it was a speed-optimized variant of !(i%8).

Can this be removed?

Probably yes, the performance impact is small. But I'm open to suggestions.

Contributor

ulteq commented Jan 12, 2016

was step&7 a typo here?

No, it was a speed-optimized variant of !(i%8).

Can this be removed?

Probably yes, the performance impact is small. But I'm open to suggestions.

only-a-ptr added a commit that referenced this pull request Jan 15, 2016

Merge pull request #557 from ulteq/node_t_Reordering
[Codechange] Clearing out and reordering of the node_t members

@only-a-ptr only-a-ptr merged commit cc1a42d into RigsOfRods:master Jan 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:node_t_Reordering branch Jan 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment