New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fixes add animation parsing (#132) #567

Merged
merged 3 commits into from Jan 14, 2016

Conversation

Projects
None yet
2 participants
@ulteq
Contributor

ulteq commented Jan 13, 2016

resolveEventName() failed due to leading whitespace in the event name

RoR.log: RigSpawner: ERROR (Keyword props) Unknown animation event: command_02

Fixes #132

ulteq added some commits Jan 13, 2016

[Bugfix] Fixes add animation parsing
resolveEventName() failed due to leading whitespace in the event name

RoR.log: RigSpawner: ERROR (Keyword props) Unknown animation event: command_02
@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Jan 14, 2016

Now it's going to fail on whitespace between keyword and colon, i.e. source : whatever

Make it E_CAPTURE_OPTIONAL( E_DELIMITER_COLON ) which eats optional whitespace on both sides:

#define E_DELIMITER_COLON "[[:blank:]]*:[[:blank:]]*"

Anyway thanks for tracking down the bug.

only-a-ptr commented on 7f77224 Jan 14, 2016

Now it's going to fail on whitespace between keyword and colon, i.e. source : whatever

Make it E_CAPTURE_OPTIONAL( E_DELIMITER_COLON ) which eats optional whitespace on both sides:

#define E_DELIMITER_COLON "[[:blank:]]*:[[:blank:]]*"

Anyway thanks for tracking down the bug.

only-a-ptr added a commit that referenced this pull request Jan 14, 2016

@only-a-ptr only-a-ptr merged commit 3048f5c into RigsOfRods:master Jan 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:addAnimationWhitespaceFix branch Jan 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment