New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fixes hook toggle triggers parsing #571

Merged
merged 1 commit into from Jan 18, 2016

Conversation

Projects
None yet
4 participants
@ulteq
Contributor

ulteq commented Jan 13, 2016

No description provided.

@disloyalpick

This comment has been minimized.

Show comment
Hide comment
@disloyalpick

disloyalpick Jan 13, 2016

👍 Man you are on a role. Keep up the amazing work. 😄

disloyalpick commented Jan 13, 2016

👍 Man you are on a role. Keep up the amazing work. 😄

@tritonas00

This comment has been minimized.

Show comment
Hide comment
@tritonas00

tritonas00 Jan 13, 2016

Collaborator

I must be dreaming... 👍

Collaborator

tritonas00 commented Jan 13, 2016

I must be dreaming... 👍

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Jan 14, 2016

Uhh ... how did I ever write such retarded checks?

Oh, right... RigsOfRods@e3c47cb?diff=unified#diff-a52911fe3e9c40ab98b42726250e304eL3749 ... I tried to make the code super-readable by separating cases where "shortkey/longkey" are trigger keys / hooktoggle hookgroups. But it escapes me why I wrote such **** checks ... sorry 😊 😊

EDIT: Does this fix RigsOfRods#333 ?

only-a-ptr commented on 53857a4 Jan 14, 2016

Uhh ... how did I ever write such retarded checks?

Oh, right... RigsOfRods@e3c47cb?diff=unified#diff-a52911fe3e9c40ab98b42726250e304eL3749 ... I tried to make the code super-readable by separating cases where "shortkey/longkey" are trigger keys / hooktoggle hookgroups. But it escapes me why I wrote such **** checks ... sorry 😊 😊

EDIT: Does this fix RigsOfRods#333 ?

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Jan 14, 2016

Contributor

EDIT: Does this fix #333 ?

No, but it is one step closer to the solution.

Contributor

ulteq commented Jan 14, 2016

EDIT: Does this fix #333 ?

No, but it is one step closer to the solution.

ulteq added a commit to ulteq/rigs-of-rods that referenced this pull request Jan 14, 2016

ulteq added a commit that referenced this pull request Jan 18, 2016

Merge pull request #571 from ulteq/hookToggleFix
[Bugfix] Fixes hook toggle triggers parsing

@ulteq ulteq merged commit 5ed060f into RigsOfRods:master Jan 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:hookToggleFix branch Jan 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment