New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Force parser to commit unfinished sections right before end #592

Merged
merged 3 commits into from Jan 28, 2016

Conversation

Projects
None yet
2 participants
@ulteq
Contributor

ulteq commented Jan 15, 2016

Fixes broken camerarail on Henschel train.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Jan 18, 2016

Member

@ulteq I need testing instructions for this.

I applied the fixes (both my suggestion + your end fix, just to be sure), but I still can't work with the camerarail. Note that I never used camerarails before, all my knowledge come from here: http://www.rigsofrods.com/wiki/pages/Truck_Description_File#Camerarail

Member

only-a-ptr commented Jan 18, 2016

@ulteq I need testing instructions for this.

I applied the fixes (both my suggestion + your end fix, just to be sure), but I still can't work with the camerarail. Note that I never used camerarails before, all my knowledge come from here: http://www.rigsofrods.com/wiki/pages/Truck_Description_File#Camerarail

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Jan 19, 2016

Contributor

@only-a-ptr Use this train: http://www.rigsofrods.com/repository/view/4340

Press 'c' until you reach the regular 3rd person camera, then press 'c' once again and your are in camera rail view.

Contributor

ulteq commented Jan 19, 2016

@only-a-ptr Use this train: http://www.rigsofrods.com/repository/view/4340

Press 'c' until you reach the regular 3rd person camera, then press 'c' once again and your are in camera rail view.

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Jan 21, 2016

Contributor

@only-a-ptr I'm sorry! I forgot to push a part of the bugfix: 5354fd4

Contributor

ulteq commented Jan 21, 2016

@only-a-ptr I'm sorry! I forgot to push a part of the bugfix: 5354fd4

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Jan 22, 2016

Member

@ulteq no problem. I'll try again on monday, I'm away from home at the moment.

Member

only-a-ptr commented Jan 22, 2016

@ulteq no problem. I'll try again on monday, I'm away from home at the moment.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Jan 27, 2016

Member

👍

Member

only-a-ptr commented Jan 27, 2016

👍

ulteq added a commit that referenced this pull request Jan 28, 2016

Merge pull request #592 from ulteq/commitUnfinishedSection
[Bugfix] Force parser to commit unfinished sections right before end

@ulteq ulteq merged commit 354e905 into RigsOfRods:master Jan 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:commitUnfinishedSection branch Jan 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment