New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fixes broken cruise control feature #593

Merged
merged 2 commits into from Jan 21, 2016

Conversation

Projects
None yet
4 participants
@ulteq
Contributor

ulteq commented Jan 16, 2016

Broken by this commit: a5724b1#diff-d47d357a254e0b1523e9a63fa4af7382R309

  • Does this affect the current engine code in any way?

Edit: I'm now pretty sure that this line is unnecessary.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Jan 20, 2016

Member

Does this affect the current engine code in any way?

You mean if the "electric engine type" implemented by Max98 changes the other engine types
behavior? I'm not able to say.

Member

only-a-ptr commented Jan 20, 2016

Does this affect the current engine code in any way?

You mean if the "electric engine type" implemented by Max98 changes the other engine types
behavior? I'm not able to say.

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 20, 2016

Contributor

Can @Max98 leave a comment?

Contributor

Hiradur commented Jan 20, 2016

Can @Max98 leave a comment?

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Jan 20, 2016

Member

@Hiradur We'll see ... but I don't think he checks up GitHub regularily.

Someone needs to poke him over Skype, but I can't at the moment

Member

only-a-ptr commented Jan 20, 2016

@Hiradur We'll see ... but I don't think he checks up GitHub regularily.

Someone needs to poke him over Skype, but I can't at the moment

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Jan 20, 2016

Contributor

You mean if the "electric engine type" implemented by Max98 changes the other engine types
behavior?

I would like to know if there was anything added after 0.4.07, that relies on setAcc(autocurAcc) being called in the else block.

Otherwise we can just merge this.

Contributor

ulteq commented Jan 20, 2016

You mean if the "electric engine type" implemented by Max98 changes the other engine types
behavior?

I would like to know if there was anything added after 0.4.07, that relies on setAcc(autocurAcc) being called in the else block.

Otherwise we can just merge this.

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 21, 2016

Contributor

👍

Contributor

Hiradur commented Jan 21, 2016

👍

ulteq added a commit that referenced this pull request Jan 21, 2016

Merge pull request #593 from ulteq/cruiseControlFix
[Bugfix] Fixes broken cruise control feature

@ulteq ulteq merged commit c918073 into RigsOfRods:master Jan 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:cruiseControlFix branch Jan 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment