New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codechange] Attempt to fix compilation on ARM #610

Merged
merged 2 commits into from Jan 20, 2016

Conversation

Projects
None yet
2 participants
@ulteq
Contributor

ulteq commented Jan 18, 2016

Should fix: #608

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 18, 2016

Are you sure this works with at least gcc and visual studio?
I usually use #elif defined(_X86_) || defined(__i386__) || defined(__386__) which should work with gcc, vs, clang and mingw afaik

Hiradur commented on source/main/physics/BeamFactory.cpp in fc2cb82 Jan 18, 2016

Are you sure this works with at least gcc and visual studio?
I usually use #elif defined(_X86_) || defined(__i386__) || defined(__386__) which should work with gcc, vs, clang and mingw afaik

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Jan 18, 2016

Owner

It does work with gcc, and should never be reached on Microsoft Windows.

Owner

ulteq replied Jan 18, 2016

It does work with gcc, and should never be reached on Microsoft Windows.

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 19, 2016

There is one problem though: If __x86_64__ is not defined by the compiler it would jump to the else path in getNumberOfCPUCores() and this would be unnoticed by the user, potentially leading to a suboptimal use of CPU cores which could only be detected by looking at RoR.log and only if you know about this...

Hiradur replied Jan 19, 2016

There is one problem though: If __x86_64__ is not defined by the compiler it would jump to the else path in getNumberOfCPUCores() and this would be unnoticed by the user, potentially leading to a suboptimal use of CPU cores which could only be detected by looking at RoR.log and only if you know about this...

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur
Contributor

Hiradur commented Jan 20, 2016

ulteq added a commit that referenced this pull request Jan 20, 2016

Merge pull request #610 from ulteq/armBuildFix
[Codechange] Attempt to fix compilation on ARM

@ulteq ulteq merged commit b867cdd into RigsOfRods:master Jan 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:armBuildFix branch Jan 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment