New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codechange] Revamped the braking code #628

Merged
merged 1 commit into from Jan 25, 2016

Conversation

Projects
None yet
3 participants
@ulteq
Contributor

ulteq commented Jan 21, 2016

Brakes in RoR apply torque against the direction of rotation of each wheel:
https://github.com/RigsOfRods/rigs-of-rods/blob/master/source/main/physics/BeamForcesEuler.cpp#L729

However the rotary speed has no effect on the amount of torque which is applied. This is changed by this PR. It will fix the following issue:

  • Greatly reduces brake induced skidding in parking positions.
    Best example: Bobcat Skid-Steer
  • Prevents brakes from making wheels spin backwards.
    Best example: 1974 Lotus 76/1
  • Removes the (now unnecessary) slopebrake.
  • Fixes the anti-lock brake and traction control pulse modulation.
[Codechange] Revamped the braking code
Fixes the anti-lock brake and traction control pulse modulation

Prevents brakes from making wheels spin backwards

Greatly reduces brake induced skidding in parking positions

Removes the (now unnecessary) slopebrake
@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Jan 23, 2016

Contributor

👍

Contributor

Hiradur commented Jan 23, 2016

👍

1 similar comment
@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Jan 25, 2016

Member

👍

Member

only-a-ptr commented Jan 25, 2016

👍

ulteq added a commit that referenced this pull request Jan 25, 2016

Merge pull request #628 from ulteq/antiSkidding
[Codechange] Revamped the braking code

@ulteq ulteq merged commit deb7a86 into RigsOfRods:master Jan 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:antiSkidding branch Jan 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment