New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codechange] Some screenshot taking improvements #669

Merged
merged 6 commits into from Jan 31, 2016

Conversation

Projects
None yet
2 participants
@ulteq
Contributor

ulteq commented Jan 30, 2016

  • Reduces the screenshot key bounce time by half
  • Adds time stamps to the screenshot file name
  • Automatically hides screen notifications before another screenshot is taken
  • Gets rid of the camera stuttering when taking a screenshot (introduced by: 1ff982a)
  • Prevents recording partially updated trucks when taking a screenshot (introduced by: 1ff982a)

Fixes: #360
Fixes: #473

[Codechange] Some screenshot taking improvements
* Reduced the screenshot key bounce time by half

* Auto hide active GUI notifications before a screenshot is taken

* Added timestamps to the screenshot filename

Fixes: #360

Fixes: #473

@only-a-ptr only-a-ptr self-assigned this Jan 30, 2016

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Jan 30, 2016

Member

On windows, it behaves funny... all code is executed without exception or any error indication, the file path is valid: "C:\\Users\\only_a_ptr\\DOCUME~1\\Rigs of Rods 0.4\\screenshot_2016-01-30_22:37:58_1.jpg" yet the screenshot is not saved.

Problem: colons are illegal in filenames on windows. OGRE obviously doesn't do error handling right here. I tried changing the colons to hyphens and it worked.

However, taking screenshot causes nasty stuttering of camera. It's very annoying while driving.

Member

only-a-ptr commented Jan 30, 2016

On windows, it behaves funny... all code is executed without exception or any error indication, the file path is valid: "C:\\Users\\only_a_ptr\\DOCUME~1\\Rigs of Rods 0.4\\screenshot_2016-01-30_22:37:58_1.jpg" yet the screenshot is not saved.

Problem: colons are illegal in filenames on windows. OGRE obviously doesn't do error handling right here. I tried changing the colons to hyphens and it worked.

However, taking screenshot causes nasty stuttering of camera. It's very annoying while driving.

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Jan 31, 2016

Contributor

colons are illegal in filenames on windows

Fixed: e902eb9

However, taking screenshot causes nasty stuttering of camera. It's very annoying while driving.

Fixed: b88a1fc

Contributor

ulteq commented Jan 31, 2016

colons are illegal in filenames on windows

Fixed: e902eb9

However, taking screenshot causes nasty stuttering of camera. It's very annoying while driving.

Fixed: b88a1fc

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Jan 31, 2016

Member

👍

Member

only-a-ptr commented Jan 31, 2016

👍

only-a-ptr added a commit that referenced this pull request Jan 31, 2016

Merge pull request #669 from ulteq/screenshotImprovements
[Codechange] Some screenshot taking improvements

@only-a-ptr only-a-ptr merged commit 1a27716 into RigsOfRods:master Jan 31, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:screenshotImprovements branch Jan 31, 2016

@ulteq ulteq referenced this pull request Feb 6, 2016

Closed

Hiding the "notice" window #240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment