New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codechange] Some changes to the parser ('cab', 'rigidifiers', 'turboprops2') #698

Merged
merged 1 commit into from Feb 2, 2016

Conversation

Projects
None yet
2 participants
@ulteq
Contributor

ulteq commented Feb 2, 2016

Truly skip unsupported rigidifiers and turboprops2 sections.

Interpret submesh sections without subsections as cab subsection.

[Codechange] Fixes 'cab' parsing on Audio 80 Quattro
Properly ignore Rigidifiers and Turboprops2
@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Feb 2, 2016

Member

rigidifiers+turboprops 👍

submesh/cab: I don't understand how this can fix any vehicle. Unless I missed something, cabs without keyword could never have worked. v0.4.0.7's parser would parse cabs ONLY if keyword cabs was encountered Parser from v0.38.66 has the same flow. But if it improves things... 👍

Member

only-a-ptr commented Feb 2, 2016

rigidifiers+turboprops 👍

submesh/cab: I don't understand how this can fix any vehicle. Unless I missed something, cabs without keyword could never have worked. v0.4.0.7's parser would parse cabs ONLY if keyword cabs was encountered Parser from v0.38.66 has the same flow. But if it improves things... 👍

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Feb 2, 2016

Contributor

I don't understand how this can fix any vehicle.

The Audi 80 has probably always had a few missing cabs.

But if it improves things...

I don't know if we should allow missing subsections. It's your decision.

Contributor

ulteq commented Feb 2, 2016

I don't understand how this can fix any vehicle.

The Audi 80 has probably always had a few missing cabs.

But if it improves things...

I don't know if we should allow missing subsections. It's your decision.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Feb 2, 2016

Member

I don't know if we should allow missing subsections. It's your decision.

Generally, we shouldn't parse anything the 0.38/0407 parsers wouldn't. But let's make an exception this time, I think we're safe enough with the regex.

Member

only-a-ptr commented Feb 2, 2016

I don't know if we should allow missing subsections. It's your decision.

Generally, we shouldn't parse anything the 0.38/0407 parsers wouldn't. But let's make an exception this time, I think we're safe enough with the regex.

ulteq added a commit that referenced this pull request Feb 2, 2016

Merge pull request #698 from ulteq/parserStuff
[Codechange] Some changes to the parser ('cab', 'rigidifiers', 'turboprops2')

@ulteq ulteq merged commit 9027a27 into RigsOfRods:master Feb 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:parserStuff branch Feb 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment