New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Overworked the reset in place feature #703

Merged
merged 9 commits into from Feb 3, 2016

Conversation

Projects
None yet
5 participants
@ulteq
Contributor

ulteq commented Feb 2, 2016

You can now translate and rotate the truck while pressing (and holding) the repair truck key.

This implements @Speciesx awesome idea on how to improve the reset in place feature.

Controls:

  • TRUCK_ACCELERATE -> translate upward
  • TRUCK_BRAKE -> translate downward
  • TRUCK_STEER_LEFT -> rotate left
  • TRUCK_STEER_RIGHT -> rotate right
  • CHARACTER_FORWARD -> translate forward
  • CHARACTER_BACKWARDS -> translate backward
  • CHARACTER_SIDESTEP_RIGHT -> translate right
  • CHARACTER_SIDESTEP_LEFT -> translate left
@tritonas00

This comment has been minimized.

Show comment
Hide comment
@tritonas00

tritonas00 Feb 2, 2016

Collaborator

Just tested, great!

Collaborator

tritonas00 commented Feb 2, 2016

Just tested, great!

@Speciesx

This comment has been minimized.

Show comment
Hide comment
@Speciesx

Speciesx Feb 2, 2016

Contributor

@ulteq
Works great.
On some vehicles like mv4, the camera shake.

Contributor

Speciesx commented Feb 2, 2016

@ulteq
Works great.
On some vehicles like mv4, the camera shake.

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Feb 2, 2016

Contributor

the camera shake

Edit: The camera shake should be gone now.

Contributor

ulteq commented Feb 2, 2016

the camera shake

Edit: The camera shake should be gone now.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Feb 3, 2016

Member

The diff is hard to read, but looks good.

Member

only-a-ptr commented Feb 3, 2016

The diff is hard to read, but looks good.

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Feb 3, 2016

Contributor

The diff is hard to read, but looks good.

Edit: It should be easier to read now.

Why smoothpos instead of AbsPosition?

Edit: The new code is using AbsPosition.

Contributor

ulteq commented Feb 3, 2016

The diff is hard to read, but looks good.

Edit: It should be easier to read now.

Why smoothpos instead of AbsPosition?

Edit: The new code is using AbsPosition.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Feb 3, 2016

Member

Reads like a child's book now ☺️

Great work 👍

One minor update please:

int Beam::reset_requested

==>>

enum Beam::ResetRequest
{
    RESET_REQUEST_NONE,
    RESET_REQUEST_....
};
ResetRequest Beam::m_reset_request
Member

only-a-ptr commented Feb 3, 2016

Reads like a child's book now ☺️

Great work 👍

One minor update please:

int Beam::reset_requested

==>>

enum Beam::ResetRequest
{
    RESET_REQUEST_NONE,
    RESET_REQUEST_....
};
ResetRequest Beam::m_reset_request

ulteq added a commit that referenced this pull request Feb 3, 2016

Merge pull request #703 from ulteq/reset-in-place-improvements
[Feature] Overworked the reset in place feature

@ulteq ulteq merged commit e6feaa6 into RigsOfRods:master Feb 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:reset-in-place-improvements branch Feb 4, 2016

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Feb 4, 2016

This will cause reset on REQUEST_RESET_NONE, too.

only-a-ptr commented on source/main/physics/Beam.cpp in f888492 Feb 4, 2016

This will cause reset on REQUEST_RESET_NONE, too.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Feb 4, 2016

Do not rely on implicit enum-> int conversion. Compare != REQUEST_RESET_NONE

only-a-ptr commented on source/main/physics/Beam.cpp in f888492 Feb 4, 2016

Do not rely on implicit enum-> int conversion. Compare != REQUEST_RESET_NONE

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Feb 4, 2016

Compare != REQUEST_RESET_NONE please.

Compare != REQUEST_RESET_NONE please.

@disloyalpick

This comment has been minimized.

Show comment
Hide comment
@disloyalpick

disloyalpick Feb 5, 2016

Truck Steer Left doesn't rotate the vehicle, but does the same as holding W key.

Same for Truck Steer Right. They just translate the vehicle left and right, instead of rotating.

disloyalpick commented Feb 5, 2016

Truck Steer Left doesn't rotate the vehicle, but does the same as holding W key.

Same for Truck Steer Right. They just translate the vehicle left and right, instead of rotating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment