New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build fix] Config in RoRConfig :) #705

Merged
merged 1 commit into from Feb 3, 2016

Conversation

Projects
None yet
3 participants
@only-a-ptr
Member

only-a-ptr commented Feb 2, 2016

Fixes current upstream build.

only-a-ptr added a commit that referenced this pull request Feb 3, 2016

Merge pull request #705 from only-a-ptr/rorconfig-config-fix
[Build fix] Cleaned up config file support, updated RoRConfig

@only-a-ptr only-a-ptr merged commit f6a16c8 into RigsOfRods:master Feb 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@only-a-ptr only-a-ptr deleted the only-a-ptr:rorconfig-config-fix branch Feb 3, 2016

@tritonas00

This comment has been minimized.

Show comment
Hide comment
@tritonas00

tritonas00 Feb 3, 2016

Collaborator

RoRConfig compiles but doesn't link here

[ 11%] Linking CXX executable ../../bin/RoRConfig
CMakeFiles/RoRConfig.dir/Configurator.cpp.o: In function initLanguage(wxString, wxString)': Configurator.cpp:(.text+0x4300): undefined reference toRoR::ConfigFile::GetStringEx(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&, std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&, std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&)'
collect2: error: ld returned 1 exit status
source/configurator/CMakeFiles/RoRConfig.dir/build.make:227: recipe for target 'bin/RoRConfig' failed
make[2]: *** [bin/RoRConfig] Error 1
CMakeFiles/Makefile2:237: recipe for target 'source/configurator/CMakeFiles/RoRConfig.dir/all' failed
make[1]: *** [source/configurator/CMakeFiles/RoRConfig.dir/all] Error 2

Collaborator

tritonas00 commented Feb 3, 2016

RoRConfig compiles but doesn't link here

[ 11%] Linking CXX executable ../../bin/RoRConfig
CMakeFiles/RoRConfig.dir/Configurator.cpp.o: In function initLanguage(wxString, wxString)': Configurator.cpp:(.text+0x4300): undefined reference toRoR::ConfigFile::GetStringEx(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&, std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&, std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&)'
collect2: error: ld returned 1 exit status
source/configurator/CMakeFiles/RoRConfig.dir/build.make:227: recipe for target 'bin/RoRConfig' failed
make[2]: *** [bin/RoRConfig] Error 1
CMakeFiles/Makefile2:237: recipe for target 'source/configurator/CMakeFiles/RoRConfig.dir/all' failed
make[1]: *** [source/configurator/CMakeFiles/RoRConfig.dir/all] Error 2

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Feb 3, 2016

Member

@tritonas00 Sorry, my bad 😊
You need to add file source/main/utils/ConfigFile.cpp to RoRConfig build.
The missing definition of GetStringEx() is there.

Member

only-a-ptr commented Feb 3, 2016

@tritonas00 Sorry, my bad 😊
You need to add file source/main/utils/ConfigFile.cpp to RoRConfig build.
The missing definition of GetStringEx() is there.

@tritonas00

This comment has been minimized.

Show comment
Hide comment
@tritonas00

tritonas00 Feb 3, 2016

Collaborator

Worked 👍

Collaborator

tritonas00 commented Feb 3, 2016

Worked 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment