New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fixed up the truck spawning code #753

Merged
merged 3 commits into from Feb 8, 2016

Conversation

Projects
None yet
2 participants
@ulteq
Contributor

ulteq commented Feb 7, 2016

  • Fixes the position of all kinds of pre-spawned trucks
  • Fixes the position of trucks spawned in spawnboxes
  • Fixes the position of trucks spawned on mesh terrains

Side-effect: Terrains without pre-spawned trucks won't automatically open a vehicle selector.

Plays nicely with: #752

ulteq added some commits Feb 7, 2016

[Bugfix] Fixed up the truck spawning code
* Fixes the position of all kinds of pre-spawned trucks

* Fixes the position of trucks spawned in spawnboxes

* Fixes the position of trucks spawned on mesh terrains
[Cleanup] Moved some code out of the InitTrucks method
We should probably remove the entire method
@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Feb 8, 2016

Member

👍
The InitTrucks() method is a leftover from old mainmenu-less RoR flow. IIRC the idea is: after map is loaded and loader automatically appears, the game is in special state, where InitTrucks will be called. Loading/reloading any subsequent vehicle won't use it.

Member

only-a-ptr commented Feb 8, 2016

👍
The InitTrucks() method is a leftover from old mainmenu-less RoR flow. IIRC the idea is: after map is loaded and loader automatically appears, the game is in special state, where InitTrucks will be called. Loading/reloading any subsequent vehicle won't use it.

ulteq added a commit that referenced this pull request Feb 8, 2016

Merge pull request #753 from ulteq/truck-spawning-revamp
[Bugfix] Fixed up the truck spawning code

@ulteq ulteq merged commit ef2d74f into RigsOfRods:master Feb 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:truck-spawning-revamp branch Feb 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment