New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codechange] Emulates the character spawn rotation of older RoR versions #797

Merged
merged 2 commits into from Apr 7, 2016

Conversation

Projects
None yet
3 participants
@ulteq
Contributor

ulteq commented Feb 23, 2016

Fixes the initial character orientation on maps like N-Labs or F1 Track

Temporary until we allow defining a spawn rotation in the terrn file

[Codechange] Emulates the character spawn rotation of older RoR versions
Fixes the initial character orientation on maps like N-Labs or F1 Track

Temporary until we allow defining a spawn rotation in the terrn file
@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Feb 24, 2016

Contributor

Not sure if I like this, is this really necesarry?

Contributor

Hiradur commented Feb 24, 2016

Not sure if I like this, is this really necesarry?

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Feb 24, 2016

Contributor

This "fix" allows you to use the same workflow as in previous versions to spawn vehicles. Otherwise you would have to carefully rotate the character into the right direction before spawning a vehicle to make sure it is aligned with the road (for example on the F1 track).

is this really necesarry?

No.

Not sure if I like this

I can live without it. It's only purpose is to temporarily make spawning vehicles more convenient.

Contributor

ulteq commented Feb 24, 2016

This "fix" allows you to use the same workflow as in previous versions to spawn vehicles. Otherwise you would have to carefully rotate the character into the right direction before spawning a vehicle to make sure it is aligned with the road (for example on the F1 track).

is this really necesarry?

No.

Not sure if I like this

I can live without it. It's only purpose is to temporarily make spawning vehicles more convenient.

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Mar 6, 2016

Contributor

I think it's ok but there should be a comment what this is for because otherwise it looks like WTF code.

Contributor

Hiradur commented Mar 6, 2016

I think it's ok but there should be a comment what this is for because otherwise it looks like WTF code.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Mar 30, 2016

Member

@ulteq 👍 For backwards compatibility, no matter how dirty it is.
However, it's necessary to add a comment above the snippet:

// Classic behavior, retained for compatibility.
// Required for maps like N-Labs or F1 Track.

Further, we musn't forget to add this to docs (when we have any, that is). I made a ticket to self: #817

Member

only-a-ptr commented Mar 30, 2016

@ulteq 👍 For backwards compatibility, no matter how dirty it is.
However, it's necessary to add a comment above the snippet:

// Classic behavior, retained for compatibility.
// Required for maps like N-Labs or F1 Track.

Further, we musn't forget to add this to docs (when we have any, that is). I made a ticket to self: #817

@only-a-ptr only-a-ptr added this to the 0.4.6.0 milestone Mar 30, 2016

@ulteq ulteq merged commit 10c0852 into RigsOfRods:master Apr 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:character-spawn-rotation-backwards-compatibility branch Apr 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment