New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collision code refactor #824

Merged
merged 11 commits into from Apr 10, 2016

Conversation

Projects
None yet
2 participants
@mikadou
Contributor

mikadou commented Apr 8, 2016

Refactor, cleanup and documentation of some collision related code.
Does not generate any performance regression for me

scenario PR master
Container test 9.5 FPS 9.5 FPS
12 cars 6.7 FPS 6.6 FPS
6 cars 12.8 FPS 12.3 FPS
5 cars 14.4 FPS 14.2 FPS
4 cars 17.8 FPS 17.8 FPS
3 cars 20.0 FPS 20.1 FPS
@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq
Contributor

ulteq commented Apr 8, 2016

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Apr 8, 2016

Contributor

Does not generate any performance regression for me

I did not measure any differences in performance either. 👍

Contributor

ulteq commented Apr 8, 2016

Does not generate any performance regression for me

I did not measure any differences in performance either. 👍

@mikadou

This comment has been minimized.

Show comment
Hide comment
@mikadou

mikadou Apr 8, 2016

Contributor

Is there a special reason why the PointColDetector update routine is not called within the collision functions?

There might have been a reason, but I can't exactly remember. How much does it bother you?

Contributor

mikadou commented Apr 8, 2016

Is there a special reason why the PointColDetector update routine is not called within the collision functions?

There might have been a reason, but I can't exactly remember. How much does it bother you?

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Apr 8, 2016

Contributor

How much does it bother you?

Not much, just leave it as is.

Contributor

ulteq commented Apr 8, 2016

How much does it bother you?

Not much, just leave it as is.

@mikadou mikadou merged commit 102144c into RigsOfRods:master Apr 10, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mikadou mikadou referenced this pull request Apr 11, 2016

Merged

Build system cleanup #758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment