New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CMake option for building with ogre 1.8 #830

Merged
merged 1 commit into from Apr 24, 2016

Conversation

Projects
None yet
3 participants
@AnotherFoxGuy
Member

AnotherFoxGuy commented Apr 15, 2016

Added CMake option for building with ogre 1.8

@AnotherFoxGuy AnotherFoxGuy changed the title from NightBuild fixes to NightBuild fix Apr 15, 2016

@mikadou

This comment has been minimized.

Show comment
Hide comment
@mikadou

mikadou Apr 15, 2016

Contributor

Nice! Does this compile with VS2012? Or are there still some issues because of C++11 features being used in the code?

Contributor

mikadou commented Apr 15, 2016

Nice! Does this compile with VS2012? Or are there still some issues because of C++11 features being used in the code?

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Apr 20, 2016

Contributor

I would suggest that we get rid of the using-directives in the header file:

instead of:

Contributor

ulteq commented Apr 20, 2016

I would suggest that we get rid of the using-directives in the header file:

instead of:

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Apr 21, 2016

Contributor

This commit is no longer needed, right?

Contributor

ulteq commented Apr 21, 2016

This commit is no longer needed, right?

@mikadou

This comment has been minimized.

Show comment
Hide comment
@mikadou

mikadou Apr 22, 2016

Contributor

Just to mention it. There is one more using declaration in a header here https://github.com/RigsOfRods/rigs-of-rods/blob/master/source/main/physics/collision/Triangle.h#L26

Contributor

mikadou commented Apr 22, 2016

Just to mention it. There is one more using declaration in a header here https://github.com/RigsOfRods/rigs-of-rods/blob/master/source/main/physics/collision/Triangle.h#L26

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Apr 23, 2016

Contributor

I've created a separate PR that focuses on the header cleanup: #842

@AnotherFoxGuy Can you close this PR and create a new one that only contains this commit: 83ff912?

Contributor

ulteq commented Apr 23, 2016

I've created a separate PR that focuses on the header cleanup: #842

@AnotherFoxGuy Can you close this PR and create a new one that only contains this commit: 83ff912?

@AnotherFoxGuy AnotherFoxGuy changed the title from NightBuild fix to Added CMake option for building with ogre 1.8 Apr 24, 2016

@AnotherFoxGuy

This comment has been minimized.

Show comment
Hide comment
@AnotherFoxGuy

AnotherFoxGuy Apr 24, 2016

Member

I've deleted the other 2 commits

Member

AnotherFoxGuy commented Apr 24, 2016

I've deleted the other 2 commits

@ulteq ulteq merged commit 32db9d6 into RigsOfRods:master Apr 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@AnotherFoxGuy AnotherFoxGuy deleted the AnotherFoxGuy:NightBuild-fix branch Apr 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment