New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codechange] Removed the use of the boost::optional class template #847

Merged
merged 1 commit into from Apr 27, 2016

Conversation

Projects
None yet
2 participants
@ulteq
Contributor

ulteq commented Apr 26, 2016

No description provided.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Apr 26, 2016

Member

I just checked boost implementation: http://www.boost.org/doc/libs/1_60_0/boost/optional/optional.hpp

It does exactly the same thing, this code is at bottom of optional_base<>:

    bool m_initialized ;
    storage_type m_storage ;

Except the header is MEGA convoluted.

Member

only-a-ptr commented Apr 26, 2016

I just checked boost implementation: http://www.boost.org/doc/libs/1_60_0/boost/optional/optional.hpp

It does exactly the same thing, this code is at bottom of optional_base<>:

    bool m_initialized ;
    storage_type m_storage ;

Except the header is MEGA convoluted.

@ulteq ulteq merged commit 4e30367 into RigsOfRods:master Apr 27, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:boost-optional-removal branch Apr 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment