New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codechange] Removed the use of the boost::starts_with algorithm #849

Merged
merged 1 commit into from Apr 27, 2016

Conversation

Projects
None yet
2 participants
@ulteq
Contributor

ulteq commented Apr 26, 2016

No description provided.

@Speciesx

This comment has been minimized.

Show comment
Hide comment
@Speciesx

Speciesx Apr 26, 2016

Contributor

Build fail with.

Error   C2039   'strnicmp': is not a member of 'std'    RoR D:\ror\dev\rigs-of-rods-boost-starts_with-removal\source\main\gui\panels\GUI_GameSettings.cpp   1121    
Error (active)      namespace "std" has no member "strnicmp"    RoR d:\ror\dev\rigs-of-rods-boost-starts_with-removal\source\main\gui\panels\GUI_GameSettings.cpp   1079    
Error (active)      namespace "std" has no member "strnicmp"    RoR d:\ror\dev\rigs-of-rods-boost-starts_with-removal\source\main\gui\panels\GUI_GameSettings.cpp   1121    
Error   C2039   'strnicmp': is not a member of 'std'    RoR D:\ror\dev\rigs-of-rods-boost-starts_with-removal\source\main\gui\panels\GUI_GameSettings.cpp   1079    
Contributor

Speciesx commented Apr 26, 2016

Build fail with.

Error   C2039   'strnicmp': is not a member of 'std'    RoR D:\ror\dev\rigs-of-rods-boost-starts_with-removal\source\main\gui\panels\GUI_GameSettings.cpp   1121    
Error (active)      namespace "std" has no member "strnicmp"    RoR d:\ror\dev\rigs-of-rods-boost-starts_with-removal\source\main\gui\panels\GUI_GameSettings.cpp   1079    
Error (active)      namespace "std" has no member "strnicmp"    RoR d:\ror\dev\rigs-of-rods-boost-starts_with-removal\source\main\gui\panels\GUI_GameSettings.cpp   1121    
Error   C2039   'strnicmp': is not a member of 'std'    RoR D:\ror\dev\rigs-of-rods-boost-starts_with-removal\source\main\gui\panels\GUI_GameSettings.cpp   1079    
@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Apr 26, 2016

Contributor

I've replaced std::strnicmp with _strnicmp.

Contributor

ulteq commented Apr 26, 2016

I've replaced std::strnicmp with _strnicmp.

@ulteq ulteq merged commit 849e05e into RigsOfRods:master Apr 27, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:boost-starts_with-removal branch Apr 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment