Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[Cleanup] Streamlined the physics simulation update routine #858
Read this first: #858 (comment)
The PR comments sound pretty good.
I can't really evaluate the code, I lost track of the simulation logic. The 1st commit which replaces custom logic with std::*future looks great, other seem to mostly move code around. But as I said, I haven't worked with it in a while.
One thing - after you're done refactoring, please make a formatting sweep of Beam.cpp and BeamFactory.cpp (eventually elsewhere) - Transform all variables to
Two main things changed:
The sim thread now only runs while Ogre is doing its thing in the background, but not while we execute code in the main thread.