New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Removed unused and dead code #863

Merged
merged 1 commit into from May 2, 2016

Conversation

Projects
None yet
2 participants
@ulteq
Contributor

ulteq commented May 1, 2016

Also removed the 0.38.67 flexbody compat code

[Cleanup] Removed unused and dead code
Also removed the 0.38.67 flexbody compat code
@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr May 2, 2016

Member

Are you positive about this? Flexbodies can be quite fragile.

Please go ahead cleaning the Flex* subsystem, it's pretty convoluted.

Member

only-a-ptr commented May 2, 2016

Are you positive about this? Flexbodies can be quite fragile.

Please go ahead cleaning the Flex* subsystem, it's pretty convoluted.

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq May 2, 2016

Contributor

The removed compatibility code was unreachable: https://github.com/RigsOfRods/rigs-of-rods/pull/863/files#diff-60ad64d47b14cb858edfc912b31128b8L34

I think it was only added to fix this issue: #16, which was later resolved by using fast_invSqrt instead of approx_invSqrt.

Are you positive about this? Flexbodies can be quite fragile.

Yes, the only actual code changes are replacing fast_normalise with normalisedCopy().
https://github.com/RigsOfRods/rigs-of-rods/pull/863/files#diff-60ad64d47b14cb858edfc912b31128b8L930

The rest of the PR is deleting unreachable, unused, obsolete code.

Contributor

ulteq commented May 2, 2016

The removed compatibility code was unreachable: https://github.com/RigsOfRods/rigs-of-rods/pull/863/files#diff-60ad64d47b14cb858edfc912b31128b8L34

I think it was only added to fix this issue: #16, which was later resolved by using fast_invSqrt instead of approx_invSqrt.

Are you positive about this? Flexbodies can be quite fragile.

Yes, the only actual code changes are replacing fast_normalise with normalisedCopy().
https://github.com/RigsOfRods/rigs-of-rods/pull/863/files#diff-60ad64d47b14cb858edfc912b31128b8L930

The rest of the PR is deleting unreachable, unused, obsolete code.

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr May 2, 2016

Member

Thanks for the clarification. 👍

Member

only-a-ptr commented May 2, 2016

Thanks for the clarification. 👍

@ulteq ulteq merged commit b9540e0 into RigsOfRods:master May 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:flex-cleanup branch May 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment